[content-service] add prestop hook to extract git status #9807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagor999
force-pushed
the
pavel/prestophook
branch
from
004b142 to
42f92fd
Compare
princerachit
reviewed
May 6, 2022
princerachit
reviewed
May 6, 2022
| layers := []fileInLayer{ | ||
| {&tar.Header{Typeflag: tar.TypeDir, Name: "/.workspace", Uid: initializer.GitpodUID, Gid: initializer.GitpodGID, Mode: 0755}, nil}, | ||
| {&tar.Header{Typeflag: tar.TypeDir, Name: "/.workspace/.gitpod", Uid: initializer.GitpodUID, Gid: initializer.GitpodGID, Mode: 0755}, nil}, | ||
| {&tar.Header{Typeflag: tar.TypeReg, Name: "/.supervisor/prestophook.sh", Uid: 0, Gid: 0, Mode: 0775, Size: int64(len(prestophookScript))}, []byte(prestophookScript)}, |
There was a problem hiding this comment.
Can you please explain why we are setting Uid and Gid to 0 but then permission to 0775?
There was a problem hiding this comment.
Uid/Gid to 0 to make sure no one else can edit\modify this file from inside the workspace (otherwise you can execute things from ring1).
775 to allow gitpod user to execute it as part of prestop hook.
jenting
reviewed
May 8, 2022
|
Nice PR! I have a question if I use the |
sagor999
force-pushed
the
pavel/prestophook
branch
from
42f92fd to
2cb0604
Compare
|
/hold I am ok to merge this PR. @sagor999 please remove the hold label when you think it is ok to merge. I have added this as there were other reviewers who left comments. |
princerachit
approved these changes
May 10, 2022
|
/unhold |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add prestop hook to extract git status when workspace is using pvc.
This is needed when workspace is using PVC and ws-daemon cannot access those files directly because:
they are on a dedicated pvc
finalize happens when container is stopped, and at that point pvc has been detached.
So we use prestop hook to do necessary work right before container will receive signal to stop (later prebuilds will extract build log in the same way for example).
Related Issue(s)
Part of #9475
How to test
You can test this as part of #9475
But for this PR, verify that workspace starts and stops normally. This PR shouldn't affect normal workflow (without PVC) and that is what should be tested in this PR.
Release Notes
Documentation