-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[content-service-api] add new snapshot initializer #9808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM
69c0db1
to
d69a9af
Compare
/werft run 👍 started the job as gitpod-build-pavel-snapshot-init.2 |
How would this be used? I.e. who would decide how when to use this initializer? Server can hardly make that decision, because workspace content storage is opaque to webapp. IMHO we should try and stick to the backup/prebuild/snapshot initializer we have today which rely on a "snapshot URL" (or in case of the backup initializer use their own convention to discover the backup). |
/werft run with-clean-slate-deployment 👍 started the job as gitpod-build-pavel-snapshot-init.3 |
@sagor999 Would be interested in this as well ☝️ So far I'm not aware WebApp is going to store information about how workspace content is stored; that was handled inside |
@csweichel this is used by #9475, if you want to see how decision is being made when to use it. |
@csweichel @geropl I extracted this from original PR at #9475 to make it easier to review those changes piece by piece, but I guess this was not very helpful. You can look at that PR to see how this initializer is used. |
@csweichel @geropl just to add, if there is a concern that there are too many initializers, once PVC approach is adopted, FromBackup and Snapshot initializers will be removed, as they will be obsolete. |
@sagor999 I've put a call in for tomorrow - I reckon we should catch up and go through those changes sync. |
After a sync with @csweichel decided it will be best to re-use existing initializers so that it is easier to add PVC support into prebuilds later on. |
Description
This just adds a new from snapshot volume initializer that is used by #9475 to add support for initializing workspace from snapshot volume.
Related Issue(s)
Part of #9475
How to test
Release Notes
Documentation