Skip to content

Pass quality to code build process #9819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2022
Merged

Conversation

andreafalzetti
Copy link
Contributor

@andreafalzetti andreafalzetti commented May 6, 2022

Description

Companion PR of gitpod-io/openvscode-server#347

The editor name is misconfigured and not showing correctly when users are using the Insider version.

Before After
Screenshot 2022-05-12 at 16 49 03 Screenshot 2022-05-12 at 16 49 13

Note: Ignore the light/dark mode

Related Issue(s)

Fixes #9380

How to test

https://gitpod.slack.com/archives/C01KGM9BH54/p1652369461003149?thread_ts=1652353405.265159&cid=C01KGM9BH54

Release Notes

NONE

@andreafalzetti andreafalzetti force-pushed the afalz/9380-fix-ide-latest-2 branch 4 times, most recently from ceb6937 to 1419799 Compare May 6, 2022 13:43
@roboquat roboquat added size/S and removed size/XS labels May 6, 2022
@andreafalzetti andreafalzetti force-pushed the afalz/9380-fix-ide-latest-2 branch 11 times, most recently from 8e17649 to 38299b1 Compare May 9, 2022 13:57
@jeanp413
Copy link
Member

jeanp413 commented May 9, 2022

@andreafalzetti just a few tips, I think we should rename ideQuality to codeQuality so that it aligned with codeCommit, and for updating product.json with jq you can do it locally in the openvscode-server repo to test it and then just copy the script to the dockerfile

@andreafalzetti andreafalzetti force-pushed the afalz/9380-fix-ide-latest-2 branch 9 times, most recently from d03793f to 6672668 Compare May 9, 2022 19:42
@roboquat roboquat added size/XS and removed size/S labels May 12, 2022
@andreafalzetti andreafalzetti changed the title [WIP] Pass quality to code build process Pass quality to code build process May 12, 2022
@andreafalzetti andreafalzetti force-pushed the afalz/9380-fix-ide-latest-2 branch from 5b68ced to 5f3d229 Compare May 12, 2022 14:56
@roboquat roboquat added size/S and removed size/XS labels May 12, 2022
@andreafalzetti andreafalzetti marked this pull request as ready for review May 12, 2022 15:29
@andreafalzetti andreafalzetti requested a review from a team May 12, 2022 15:29
@jeanp413
Copy link
Member

Comment on the openvscode-server PR gitpod-io/openvscode-server#347 (comment)

@jeanp413 jeanp413 self-requested a review May 12, 2022 23:38
@andreafalzetti andreafalzetti force-pushed the afalz/9380-fix-ide-latest-2 branch from 5f3d229 to cb51dcd Compare May 13, 2022 14:58
@andreafalzetti andreafalzetti force-pushed the afalz/9380-fix-ide-latest-2 branch 2 times, most recently from 51da3bc to a24e4db Compare May 16, 2022 17:16
@jeanp413
Copy link
Member

Looks good!
image

@andreafalzetti andreafalzetti force-pushed the afalz/9380-fix-ide-latest-2 branch from a24e4db to 406676b Compare May 16, 2022 18:15
@jeanp413 jeanp413 self-requested a review May 16, 2022 18:19
@roboquat roboquat merged commit c85e68f into main May 16, 2022
@roboquat roboquat deleted the afalz/9380-fix-ide-latest-2 branch May 16, 2022 18:37
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/S team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode about dialog don't show insiders label
3 participants