-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Pass quality to code build process #9819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceb6937
to
1419799
Compare
8e17649
to
38299b1
Compare
@andreafalzetti just a few tips, I think we should rename |
d03793f
to
6672668
Compare
5b68ced
to
5f3d229
Compare
Comment on the openvscode-server PR gitpod-io/openvscode-server#347 (comment) |
5f3d229
to
cb51dcd
Compare
jeanp413
reviewed
May 13, 2022
jeanp413
reviewed
May 13, 2022
51da3bc
to
a24e4db
Compare
jeanp413
reviewed
May 16, 2022
a24e4db
to
406676b
Compare
jeanp413
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deployed: IDE
IDE change is running in production
deployed
Change is completely running in production
release-note-none
size/S
team: IDE
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Companion PR of gitpod-io/openvscode-server#347
The editor name is misconfigured and not showing correctly when users are using the Insider version.
Note: Ignore the light/dark mode
Related Issue(s)
Fixes #9380
How to test
https://gitpod.slack.com/archives/C01KGM9BH54/p1652369461003149?thread_ts=1652353405.265159&cid=C01KGM9BH54
Release Notes