Skip to content

[server] Return NOT_FOUND when workspace does not exist #9828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022
Merged

[server] Return NOT_FOUND when workspace does not exist #9828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/server/src/workspace/gitpod-server-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@ export class GitpodServerImpl implements GitpodServerWithTracing, Disposable {
protected async internalGetWorkspace(id: string, db: WorkspaceDB): Promise<Workspace> {
const ws = await db.findById(id);
if (!ws) {
throw new Error(`No workspace with id '${id}' found.`);
throw new ResponseError(ErrorCodes.NOT_FOUND, "Workspace not found.");
}
return ws;
}
Expand Down