[public-api] Convert server errors to appropriate RPC errors #9829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/pub-api-convert-server-errs
branch
2 times, most recently
from
2830a0c to
173713d
Compare
csweichel
reviewed
May 9, 2022
easyCZ
force-pushed
the
mp/pub-api-convert-server-errs
branch
from
173713d to
3ab28e8
Compare
csweichel
approved these changes
May 12, 2022
laushinka
approved these changes
May 13, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Server errors are returned largely as string errors into the library we're using. We need to parse them somewhat to know what to return to the caller.
In this PR, we first extract info from the server errors and wrap them with a corresponding gRPC status code, we then take this on the GetWorkspace handler to return meaningful user facing errors out, without the underlying protocol errors. In effect, we have
internalandpublicerrors, and the internal details shouldn't be returned the caller.Related Issue(s)
How to test
Unit tests
Release Notes
Documentation
NONE