Improve handling of preview deployment failures on main #9837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the error would only be sent to Slack, and added to the span but wouldn't be visible in the actual Werft logs. This fixes that
mads-hartmann
force-pushed
the
mads-hartmann/werft-jobs-fail-often-9659
branch
from
70eda95 to
c559563
Compare
Rather than relying on catching errors everywhere and using exit 0 in the implementation of preview environment deployments, this moves the try/catch all the way to the top. This ensure that preview deployment errors never breaks the main build. Using exit 0 is also not ideal as it means we might not flush traces, so getting rid of those is nice.
mads-hartmann
force-pushed
the
mads-hartmann/werft-jobs-fail-often-9659
branch
from
c559563 to
9b83bff
Compare
meysholdt
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves how we handle preview deployment failures on main.
Rather than relying on catching errors everywhere and using
exit 0in the implementation of preview environment deployments, this moves thetry/catchall the way to the top. This ensure that preview deployment errors neverbreaks the main build.
Additionally the this improves a few other things as well
exit 0means that all of our shutdown logic like flushing traces doesn't get executed which might result in missing spans. So getting rid of those is nice.werft.failwill no longer end all spans. We have afinallyhandler that does that anyway, and ending all the spans in thefailcode means we close the root span before the job is actually done (e.g. our top catch/finally logic hasn't been executed)Related Issue(s)
Fixes #9659
Fixes https://github.com/gitpod-io/ops/issues/947
How to test
I have not tried to inject errors, so we won't know for sure this does the right thing until this is merged and we see a preview environment deployment failure on main.
Release Notes
Documentation
N/A