Skip to content

[licensor] cleanup duplicate license types #9880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022
Merged

[licensor] cleanup duplicate license types #9880

merged 1 commit into from
May 10, 2022

Conversation

nandajavarma
Copy link
Contributor

Description

This is a tiny PR that removes the redundancy in Licence type names. Currently, we have different enum constants for Replicated and the original(gitpod) license. This is unnecessary and there is no use case of having separate values for this.

Related Issue(s)

Fixes #

How to test

This PR makes no functionality changes

Release Notes

NONE

Documentation

@nandajavarma nandajavarma requested a review from a team May 9, 2022 22:41
@nandajavarma nandajavarma requested a review from mrsimonemms May 9, 2022 22:41
@roboquat roboquat added the size/M label May 9, 2022
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 9, 2022
@roboquat roboquat merged commit 0ab2a8d into main May 10, 2022
@roboquat roboquat deleted the nvn/enum-cleanup branch May 10, 2022 08:06
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants