[public-api] Cleanup registration of metrics #9896
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/pub-api-cleaner-registry
branch
from
bf20c37 to
9df373b
Compare
|
Lol was just about to make the adjustments! #blazingfast |
laushinka
reviewed
May 10, 2022
| @@ -36,7 +34,7 @@ func TestConnectionCreationWasTracked(t *testing.T) { | |||
| WorkspaceId: "some-ID", | |||
| }) | |||
|
|
|||
| count, err := testutil.GatherAndCount(registry) | |||
| count, err := testutil.GatherAndCount(srv.MetricsRegistry()) | |||
| assert.NoError(t, err) | |||
| assert.Equal(t, 1, count) | |||
There was a problem hiding this comment.
This now fails because it found more. Is it because now we're using the global registry, there are more metrics that went along with it?
There was a problem hiding this comment.
That's because the srv.MetricsRegistry() has more metrics than just the 1. We can pass an argument to GatherAndCount to filter on only the ones we are testing. Will fix.
easyCZ
force-pushed
the
mp/pub-api-cleaner-registry
branch
from
9df373b to
abf0e1e
Compare
|
To make the tests work, a significant refactor was needed. This feels unnecessary for the sake of testing a metric so will close this PR and cut a new one with just the refactor. We'll remove the test to reduce the need for indirection just for the sake of the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #9879 merged, there is always a
prometheus.Registryavailable on the server for use, so we can simplify our logic.Related Issue(s)
Fixes #
How to test
Unit passes
Release Notes
Documentation
NONE