Skip to content

Improve workspace load test automation #9940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 16, 2022
Merged

Improve workspace load test automation #9940

merged 5 commits into from
May 16, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented May 11, 2022

Description

For a description of the changes and a demo, please see the Loom video. In short:

Related Issue(s)

Fixes #9901, #9722, #9724

How to test

  • Spin up a preview vm (or an ephemeral cluster)
  • Start loadgen tool with loadgen benchmark prod-benchmark.yaml --tls [pathToTlsConfig] --host [addressOfWsManager] .Tls config can be retrieved with gpctl clusters get-tls-config (ensure you have the correct kubeconfig). You can port-forward ws-manager with e.g. kubectl port-forward [ws-manager-pod] 12001:8080

Release Notes

None

Documentation

@Furisto Furisto requested a review from a team May 11, 2022 12:55
sagor999
sagor999 reviewed May 11, 2022
View reviewed changes
jenting
jenting reviewed May 16, 2022
View reviewed changes
dev/loadgen/cmd/benchmark.go
},
},
WorkspaceLocation: "workspace-stress",
Envvars: scenario.Environment,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Furisto
Copy link
Member Author

Furisto commented May 16, 2022

@jenting @sagor999 PTAL

@roboquat roboquat merged commit cf2c0aa into main May 16, 2022
@roboquat roboquat deleted the fo/loadgen branch May 16, 2022 19:57
jenting
jenting reviewed May 17, 2022
View reviewed changes
dev/loadgen/pkg/observer/success.go
o.m.Unlock()

case loadgen.SessionWorkspaceUpdate:
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brackets is redundant.

@kylos101 kylos101 mentioned this pull request May 17, 2022
Closed
7 tasks
@Furisto Furisto mentioned this pull request May 27, 2022
Merged
@jenting jenting mentioned this pull request Jun 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting left review comments

@sagor999 sagor999 sagor999 approved these changes

Assignees
No one assigned
Labels
release-note-none size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workspaces started with loadgen can be gracefully terminated via gpctl stop
4 participants
@Furisto @sagor999 @jenting @roboquat