Skip to content

[content-service] fix gcloud test #9987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022
Merged

[content-service] fix gcloud test #9987

merged 1 commit into from
May 12, 2022

Conversation

sagor999
Copy link
Contributor

Description

fix gcloud test error that was introduced by #9943
we are now bubbling up error instead of silently dropping it, and had to update the test to account for it

Related Issue(s)

Fixes #

How to test

Release Notes

none

Documentation

@sagor999 sagor999 marked this pull request as ready for review May 12, 2022 20:08
@sagor999 sagor999 requested a review from a team May 12, 2022 20:08
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 12, 2022
@roboquat roboquat merged commit 2d40ac9 into main May 12, 2022
@roboquat roboquat deleted the pavel/fix-test branch May 12, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants