Skip to content

workspacekit: Record the errors of connecting to ws-daemon #9996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented May 13, 2022

Description

workspacekit: Record the errors of connecting to ws-daemon

Related Issue(s)

Relates: #9673

How to test

Open a workspace

Release Notes

None

Documentation

No

@utam0k utam0k force-pushed the to/iws-conn-err branch from 33ec450 to 4217bf7 Compare May 16, 2022 00:17
@utam0k utam0k force-pushed the to/iws-conn-err branch from 4217bf7 to 1dd1c6a Compare May 16, 2022 06:19
@utam0k
Copy link
Contributor Author

utam0k commented May 16, 2022

@csweichel @jenting PTAL

Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@roboquat roboquat merged commit 6b5f345 into main May 16, 2022
@roboquat roboquat deleted the to/iws-conn-err branch May 16, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants