Cherry-pick from tailscale #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible to accept auth type "none" before, but not dynamically at runtime as a function of the ConnMetadata like the other auth types' callback hooks. See golang/go#51994 and https://go-review.googlesource.com/c/crypto/+/395314 Change-Id: I83ea80901d4977d8f78523e3d1e16e0a7df5b172 (cherry picked from commit 4a431fab27b09acb1458fbb8709e12b2760e58a2)
Signed-off-by: Maisem Ali <[email protected]>
This allows specifying an ImplicitAuthMethod associated with NoClientAuthCallback. Signed-off-by: Maisem Ali <[email protected]>
Co-Authored-By: Maisem Ali <[email protected]> Signed-off-by: Brad Fitzpatrick <[email protected]>
Signed-off-by: Maisem Ali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from tailscale https://github.com/tailscale/golang-x-crypto/