Skip to content

sha256Hash fails to hash symlink to directory #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreafalzetti opened this issue Nov 10, 2022 · 1 comment · Fixed by #113
Closed

sha256Hash fails to hash symlink to directory #112

andreafalzetti opened this issue Nov 10, 2022 · 1 comment · Fixed by #113
Labels
bug Something isn't working

Comments

@andreafalzetti
Copy link

andreafalzetti commented Nov 10, 2022

Bug description

When building the image for JetBrains Rider, we hit this error:

 build  components/ide/jetbrains/image:download-rider-latest  (version 249f098fb2645cf5fadbd511dcee0ec35561bb05)

[components/ide/jetbrains/image:download-rider-latest] build started (version 249f098fb2645cf5fadbd511dcee0ec35561bb05)
[components/ide/jetbrains/image:download-rider-latest] package build failed
[components/ide/jetbrains/image:download-rider-latest] Reason: cannot compute hash of /backend/bin/JBDevice.framework/Versions/Current: read /tmp/build/components-ide-jetbrains-image--download-rider-latest.249f098fb2645cf5fadbd511dcee0ec35561bb05/backend/bin/JBDevice.framework/Versions/Current: is a directory
:cloud:  uploading build artifacts to remote cache
build failed
Reason: build failed
FATA[0041] build failed  

In the JetBrains tar.gz there are a couple of files which are symlink other directories. Example:

  • JBDevice.framework/Versions/Current
  • Bridge.framework/Versions/Current

Those are the ones causing the problem

Related code in Leeway: https://github.com/gitpod-io/leeway/blob/main/pkg/leeway/provenance.go#L332
Related PR in gitpod: gitpod-io/gitpod#14524

Steps to reproduce

  1. Start a workspace for this PR: [JetBrains] Add Rider & CLion to beta gitpod#14524
  2. Edit components/ide/jetbrains/image/download.sh and comment out the rm commands
  3. Run leeway build components/ide/jetbrains/image:download-rider-latest

Expected behavior

No response

Example repository

No response

Anything else?

No response

@andreafalzetti andreafalzetti added the bug Something isn't working label Nov 10, 2022
@andreafalzetti andreafalzetti changed the title sha256Hash fails to hash directory sha256Hash fails to hash symlink to directory Nov 10, 2022
@meysholdt
Copy link
Member

Context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants