Skip to content

Refactor inTotoMaterials to skip directories #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 10, 2022

Description

Skip hash of directories

Related Issue(s)

Fixes #112

Release Notes

NONE

@werft-gitpod-dev-com
Copy link

cannot start job - please talk to whoever's in charge of your Werft installation

@aledbf aledbf force-pushed the aledbf/inTotoMaterials branch from eb150df to 26d7d91 Compare November 10, 2022 15:04
@aledbf
Copy link
Member Author

aledbf commented Nov 10, 2022

/werft run

👎 cannot start job - please talk to whoever's in charge of your Werft installation

@andreafalzetti
Copy link

andreafalzetti commented Nov 11, 2022

Thanks @aledbf for raising this PR 🙏

I've tried the following:

  • Added script: install-leeway-from-git.sh [1]
  • Changed the default repo to be git clone https://github.com/aledbf/leeway.git --branch "$BRANCH"
  • Run ./install-leeway-from-git.sh aledbf/inTotoMaterials
  • Leeway gets updated successfully, then I re-run the build cmd which I know it fails, it keeps failing leeway build components/ide/jetbrains/image:download-rider-latest

Error:

☁️  checking remote cache for past build artifacts
🔧  build  components/ide/jetbrains/image:download-rider-latest  (version a85c6ba1bb27af0ba81153753bb82cc171d12462)

[components/ide/jetbrains/image:download-rider-latest] build started (version a85c6ba1bb27af0ba81153753bb82cc171d12462)
[components/ide/jetbrains/image:download-rider-latest] package build failed
[components/ide/jetbrains/image:download-rider-latest] Reason: cannot compute hash of /backend/bin/JBDevice.framework/Resources: read /tmp/build/components-ide-jetbrains-image--download-rider-latest.a85c6ba1bb27af0ba81153753bb82cc171d12462/backend/bin/JBDevice.framework/Resources: is a directory
☁️  uploading build artifacts to remote cache
build failed
Reason: build failed
FATA[0040] build failed      

Am I missing something?

@aledbf aledbf merged commit 3914853 into gitpod-io:main Nov 11, 2022
@aledbf
Copy link
Member Author

aledbf commented Nov 11, 2022

@andreafalzetti after merging the fix It works

gitpod /workspace/gitpod/scripts (afalz/14497-jb-ides) $ ./install-leeway.sh main
Cloning Leeway into /tmp/tmp.EuJO7MuN8Y
Cloning into 'leeway'...
remote: Enumerating objects: 2116, done.
remote: Counting objects: 100% (608/608), done.
remote: Compressing objects: 100% (244/244), done.
remote: Total 2116 (delta 391), reused 470 (delta 342), pack-reused 1508
Receiving objects: 100% (2116/2116), 1.36 MiB | 12.65 MiB/s, done.
Resolving deltas: 100% (1326/1326), done.
go: downloading github.com/segmentio/textio v1.2.0
go: downloading github.com/creack/pty v1.1.18
go: downloading github.com/spf13/cobra v1.6.1
go: downloading github.com/gookit/color v1.5.2
go: downloading github.com/disiqueira/gotree v1.0.0
go: downloading golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2
go: downloading github.com/in-toto/in-toto-golang v0.3.3
go: downloading sigs.k8s.io/bom v0.1.0
go: downloading github.com/dop251/goja v0.0.0-20221106173738-3b8a68ca89b4
go: downloading github.com/fsnotify/fsnotify v1.6.0
go: downloading github.com/imdario/mergo v0.3.13
go: downloading github.com/minio/highwayhash v1.0.2
go: downloading github.com/opencontainers/runtime-spec v1.0.3-0.20210326190908-1c3f411f0417
go: downloading golang.org/x/mod v0.6.0
go: downloading golang.org/x/sync v0.1.0
go: downloading golang.org/x/sys v0.1.0
go: downloading github.com/karrick/godirwalk v1.17.0
go: downloading github.com/coreos/go-systemd/v22 v22.5.0
go: downloading github.com/godbus/dbus/v5 v5.1.0
go: downloading github.com/moby/sys/mountinfo v0.6.2
go: downloading github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e
go: downloading sigs.k8s.io/release-utils v0.7.3
go: downloading golang.org/x/text v0.4.0
go: downloading github.com/go-sourcemap/sourcemap v2.1.3+incompatible
go: downloading github.com/dlclark/regexp2 v1.7.0
go: downloading github.com/shibumi/go-pathspec v1.3.0

Replacing /usr/bin/leeway with the newly build binary.
gitpod /workspace/gitpod/scripts (afalz/14497-jb-ides) $ leeway build components/ide/jetbrains/image:download-rider-latest
☁️  checking remote cache for past build artifacts
🔧  build  components/ide/jetbrains/image:download-rider-latest  (version 4578991859aaa3e8e86d04ba4723649ebc4d22ed)

[components/ide/jetbrains/image:download-rider-latest] build started (version 4578991859aaa3e8e86d04ba4723649ebc4d22ed)
[components/ide/jetbrains/image:download-rider-latest] package build succeded (180.85s)
☁️  uploading build artifacts to remote cache

build succeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sha256Hash fails to hash symlink to directory
2 participants