Skip to content

Patch gsutil 401 if not logged in #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Patch gsutil 401 if not logged in #119

merged 1 commit into from
Nov 16, 2022

Conversation

vulkoingim
Copy link
Contributor

@vulkoingim vulkoingim commented Nov 16, 2022

Description

quick patch to solve the gsutil permission issue. We should use the client library to talk to GCS, as it will give us a better experience.

Your implementation here was handling this @mads-hartmann , I broke it 🙈

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

@werft-gitpod-dev-com
Copy link

cannot start job - please talk to whoever's in charge of your Werft installation

@vulkoingim vulkoingim requested a review from a team November 16, 2022 09:45
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #119 (771d925) into main (df44358) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #119      +/-   ##
========================================
- Coverage   8.44%   8.44%   -0.01%     
========================================
  Files         19      19              
  Lines       2971    2972       +1     
========================================
  Hits         251     251              
- Misses      2684    2685       +1     
  Partials      36      36              

@vulkoingim vulkoingim merged commit 4caf42a into main Nov 16, 2022
@vulkoingim vulkoingim deleted the aa/fix-gs-401 branch November 16, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant