-
Notifications
You must be signed in to change notification settings - Fork 476
Add analytic for the language of opened files #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8f04058
to
b78c0ee
Compare
Should we change
|
|
no idea what openvscode-server/extensions/package.json Lines 12 to 13 in 25542be
I will not change package.json file in gitpod-desktop extension. Updated PR desc to add how to package desktop extension |
b78c0ee
to
4fc2b56
Compare
4fc2b56
to
b78c0ee
Compare
b78c0ee
to
e087aa7
Compare
It would be cool if you can have a look (with another PR) how to get |
e087aa7
to
ae2474f
Compare
@mustard-mh ready for review? |
After werft done👍 https://werft.gitpod-dev.com/job/gitpod-build-hw-vs-lang.9 |
ae2474f
to
a05f886
Compare
a05f886
to
2e8e6ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mustard-mh Could you back port it please to released version? 🙏 |
Will do it tomorrow |
This PR fixes #
Related gitpod-io/gitpod#9967
How to test
latest(insiders)
code (check if code about commit is2e8e6adbde94e4eae45000067f6e92b1f4412c03
vscode_active_language
, see track log detailsOpen workspace with Desktop IDE, see if track works like browser one
Cases
README.md
see track withlang=markdown
andext=md
a.ts
see if track withlang=typescript
andext=ts
b.ts
, should no new tracking event for langtypescript
Opena.ts
andb.json
as current editing file (split editor), reload page, see if track send withtypescript
andjson
Log
if we selectOutput
tab in terminal tabbarHow to test with Desktop Code
We need to re-install
gitpod-remote
extensionnpx gulp package-gitpod-marketplace-extensions
, to package remote extension💡 file ext like
vue
svelte
etc vscode not detect them as some language but plaintext. You need to install extensions to support them. search extension with their name and try it.TODO