Skip to content

Add analytic for the language of opened files #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2022

Conversation

mustard-mh
Copy link

@mustard-mh mustard-mh commented May 12, 2022

This PR fixes #

Related gitpod-io/gitpod#9967

How to test

Open workspace with Desktop IDE, see if track works like browser one

Cases

  • Open README.md see track with lang=markdown and ext=md
  • Create a.ts see if track with lang=typescript and ext=ts
  • Create another ts file b.ts, should no new tracking event for lang typescript
  • Close all files, reload page, no tracking sent
  • Open a.ts and b.json as current editing file (split editor), reload page, see if track send with typescript and json
  • Just found that it will report as Log if we select Output tab in terminal tabbar

How to test with Desktop Code

We need to re-install gitpod-remote extension

  • Run npx gulp package-gitpod-marketplace-extensions, to package remote extension
  • Download remote vsix to you computer
  • Open workspace with Desktop Code in prev env
  • Upload vsix to your workspace
  • Install vsix with file (you can uninstall prev one to make a confirm
Image

💡 file ext like vue svelte etc vscode not detect them as some language but plaintext. You need to install extensions to support them. search extension with their name and try it.

TODO

  • Add track call event after event name confirm notion. Added

@mustard-mh mustard-mh marked this pull request as ready for review May 12, 2022 19:12
@mustard-mh
Copy link
Author

Should we change compile script to gulp gitpod:package-extension:gitpod? Previous one not works

"compile": "gulp compile-extension:gitpod",

@jeanp413
Copy link
Member

jeanp413 commented May 13, 2022

gitpod:package-extension:gitpod is for creating the vsix if there's a task that only compiles then go ahead en fix it or add another script called package

@mustard-mh
Copy link
Author

no idea what gulp will do, we watch all extensions change and compile them all here in extensions/package.json

"compile": "../node_modules/.bin/tsc -b",
"watch": "../node_modules/.bin/tsc -b -w"

I will not change package.json file in gitpod-desktop extension. Updated PR desc to add how to package desktop extension

@mustard-mh mustard-mh marked this pull request as draft May 13, 2022 05:39
@mustard-mh mustard-mh mentioned this pull request May 13, 2022
1 task
@akosyakov
Copy link
Member

It would be cool if you can have a look (with another PR) how to get jb_active_language event as well via JB backend plugin.

@akosyakov
Copy link
Member

@mustard-mh ready for review?

@mustard-mh
Copy link
Author

@mustard-mh ready for review?

After werft done👍 https://werft.gitpod-dev.com/job/gitpod-build-hw-vs-lang.9

@mustard-mh mustard-mh marked this pull request as ready for review May 13, 2022 15:13
@mustard-mh mustard-mh requested review from jeanp413 and akosyakov May 13, 2022 15:13
@mustard-mh mustard-mh requested a review from jeanp413 May 13, 2022 19:11
@mustard-mh
Copy link
Author

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mustard-mh mustard-mh merged commit 0fee61d into gp-code/main May 16, 2022
@akosyakov
Copy link
Member

@mustard-mh Could you back port it please to released version? 🙏

@jeanp413 jeanp413 deleted the hw/opened-lang branch May 16, 2022 13:22
@mustard-mh
Copy link
Author

Could you back port it please to released version? 🙏

Will do it tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants