extensions observability #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
force-pushed
the
ak/ext_metrics
branch
2 times, most recently
from
63796b8 to
9d2bac4
Compare
2 tasks
mustard-mh
force-pushed
the
gp-code/main
branch
from
09d3205 to
3550452
Compare
akosyakov
force-pushed
the
ak/ext_metrics
branch
from
9d2bac4 to
88ba007
Compare
andreafalzetti
approved these changes
Sep 2, 2022
jeanp413
force-pushed
the
gp-code/main
branch
from
3550452 to
3c106dd
Compare
jeanp413
reviewed
Sep 5, 2022
src/vs/workbench/services/telemetry/browser/telemetryService.ts
Outdated
Show resolved
Hide resolved
akosyakov
force-pushed
the
ak/ext_metrics
branch
from
88ba007 to
cd660e9
Compare
akosyakov
force-pushed
the
ak/ext_metrics
branch
from
cd660e9 to
5f2621e
Compare
|
As I was on holiday on friday I didn't have time to do a proper review, will add comments so maybe they are addressed in the future |
jeanp413
reviewed
Sep 5, 2022
|
|
||
| export class GitpodInsightsAppender implements ITelemetryAppender { | ||
| private _baseProperties: { appName: string; uiKind: 'web'; version: string }; | ||
| private readonly _baseProperties: { appName: string; uiKind: 'web'; version: string }; | ||
| private readonly devMode = this.productService.nameShort.endsWith(' Dev'); |
There was a problem hiding this comment.
This doesn't look nice, should be moved to workbench.ts and if true then set gitpodPreview to undefined and use that as a check here
jeanp413
reviewed
Sep 5, 2022
| window.postMessage({ type: 'vscode_telemetry', event: trackMessage.event, properties: trackMessage.properties }, '*'); | ||
| } | ||
|
|
||
| private async sendMetrics(eventName: string, data: any): Promise<void> { |
There was a problem hiding this comment.
The browser gitpodInsightsAppender.ts is just and edge for the reconnection events when we lose connection to the remote server, all other events will be send to the remote so not sure if we need the sendMetrics logic here
jeanp413
reviewed
Sep 5, 2022
|
|
||
| export function mapTelemetryData(kind: SenderKind, eventName: string, data: any): RemoteTrackMessage | undefined { | ||
| if (kind === SenderKind.Node) { |
jeanp413
reviewed
Sep 5, 2022
| export class GitpodInsightsAppender implements ITelemetryAppender { | ||
|
|
||
| private _asyncAIClient: Promise<GitpodConnection> | null; | ||
| private _defaultData: { [key: string]: any } = Object.create(null); | ||
| private _baseProperties: { appName: string; uiKind: 'web'; version: string }; | ||
| private readonly supervisor = new SupervisorConnection(); | ||
| private readonly devMode = this.productName.endsWith(' Dev'); |
There was a problem hiding this comment.
Same as before, move to workbench.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting for gitpod-io/gitpod#12539. See this PR for explanation and how to test.