[gp-code] measure all sessions vs errored sessions #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
akosyakov
force-pushed
the
gp-code/main
branch
from
b0a9999 to
cf7bec5
Compare
jeanp413
force-pushed
the
gp-code/main
branch
from
cf7bec5 to
48bb437
Compare
akosyakov
force-pushed
the
gp-code/main
branch
from
1518919 to
e8e8a93
Compare
filiptronicek
force-pushed
the
ft/measure-errored-percent-sessions
branch
from
b309d99 to
30d27c7
Compare
akosyakov
force-pushed
the
gp-code/main
branch
from
e2c3ab1 to
58baf65
Compare
filiptronicek
force-pushed
the
ft/measure-errored-percent-sessions
branch
from
30d27c7 to
1f46172
Compare
akosyakov
reviewed
Sep 12, 2022
filiptronicek
force-pushed
the
ft/measure-errored-percent-sessions
branch
3 times, most recently
from
84afe45 to
f0949e3
Compare
filiptronicek
commented
Sep 12, 2022
Comment on lines
62
to
65
| if (resourceSource.match(new RegExp(/\/build\/ide\/code:.+\/__files__\//g))) { | ||
| // TODO(ak) reconsider how to hide knowledge of VS Code from supervisor frontend, i.e instrument amd loader instead | ||
| labels['resource'] = 'vscode-web-workbench'; | ||
| } |
There was a problem hiding this comment.
I wonder if this check is relevant here, because we are checking for errors in the whole window and there may be resources like in <iframe>s which may trigger this, so the check is perhaps justified here.
akosyakov
force-pushed
the
gp-code/main
branch
from
b133f64 to
1493922
Compare
filiptronicek
force-pushed
the
ft/measure-errored-percent-sessions
branch
from
f0949e3 to
6fc5d45
Compare
jeanp413
force-pushed
the
gp-code/main
branch
from
ee48889 to
8a04b4e
Compare
akosyakov
force-pushed
the
ft/measure-errored-percent-sessions
branch
from
6fc5d45 to
815cfe0
Compare
akosyakov
reviewed
Sep 14, 2022
mustard-mh
force-pushed
the
ft/measure-errored-percent-sessions
branch
from
357e46d to
c2e7e9c
Compare
mustard-mh
reviewed
Sep 14, 2022
| const headers: http.OutgoingHttpHeaders = { | ||
| 'Content-Type': 'text/html', | ||
| 'Content-Security-Policy': cspDirectives | ||
| 'Content-Security-Policy': this._environmentService.isBuilt ? cspDirectives : allowAllCSP |
There was a problem hiding this comment.
Add this to make workbench.html onerror works in dev mode. allowAllCSP value comes from stackoverflow
mustard-mh
approved these changes
Sep 15, 2022
mustard-mh
force-pushed
the
ft/measure-errored-percent-sessions
branch
from
c2e7e9c to
e2c44a2
Compare
iQQBot
approved these changes
Sep 16, 2022
akosyakov
reviewed
Sep 16, 2022
| } | ||
| url.pathname = '/metrics-api'; | ||
| return url.toString(); | ||
| let workspaceId = null; |
There was a problem hiding this comment.
@mustard-mh we should be careful with creating global variables, we had gitpodMetricsAddCounter on purpose to avoid polluting global scope
akosyakov
reviewed
Sep 16, 2022
|
|
||
| // TODO collect errors, we can capture resourceSource, error if possible with stack, message, name, and window URL |
There was a problem hiding this comment.
I'll clean some comments up by push commit to gp-code/main, and improve this #428 (comment)
akosyakov
reviewed
Sep 16, 2022
| <script type="text/javascript" src="/_supervisor/frontend/main.js" onerror="onVsCodeWorkbenchError(event)" charset="utf-8"></script> | ||
| <script src="./static/out/vs/loader.js" onerror="onVsCodeWorkbenchError(event)" ></script> | ||
| <script src="./static/out/vs/webPackagePaths.js" onerror="onVsCodeWorkbenchError(event)" ></script> | ||
| <script type="text/javascript" src="/_supervisor/frontend/main.js" onerror="onVsCodeWorkbenchError(event)" charset="utf-8" crossorigin="anonymous"></script> |
There was a problem hiding this comment.
@mustard-mh crossorigin="anonymous" it does not seem you are making use of it, i.e. idea was to add it if we want to collect information about script errors, onVsCodeWorkbenchError should report them too then
There was a problem hiding this comment.
If we add this, supervisor frontend can use it too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gitpod-io/gitpod#12702 for details