-
Notifications
You must be signed in to change notification settings - Fork 478
Add UnhandledError telemetry error report #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d9a1a9c
to
5a39cce
Compare
@@ -4,7 +4,7 @@ | |||
"private": true, | |||
"dependencies": { | |||
"@gitpod/gitpod-protocol": "main", | |||
"@gitpod/ide-metrics-api-grpcweb": "ak-ext-metrics", | |||
"@gitpod/ide-metrics-api-grpcweb": "^0.0.1-main.4783", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Global search with "@gitpod/ide-metrics-api-grpcweb": "ak-ext-metrics"
and found it. Why we need this dependency in the remote
and remote/web
folders?
cc @akosyakov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to distribute them for web (remote/web) and backend (remote) during the build, in the root only dev time deps
ec919b2
to
7364fa1
Compare
1e7f627
to
6f5fd45
Compare
7364fa1
to
a923830
Compare
7364fa1
to
a923830
Compare
6f5fd45
to
754b44f
Compare
a923830
to
e6eabe6
Compare
a8e3644
to
94bdd90
Compare
This error stack is omitted, since vscode thought it's private data
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through the code, it looks like it would do what we want. Clean up history and bring it in?
94bdd90
to
4d78e6d
Compare
Add UnhandledError telemetry error report
How to Test
Use latest code and open workspace in preview env https://hw-vserror-report.preview.gitpod-dev.com/workspaces
Browser Error Catch
vscode-web
. Access log detail,userId
workspaceId
instanceId
should existsvscode-server
since we filter themServer Error Catch
TODO...
Need to add debug commit for it, but we can manually get an error by changing browser resources code, to make
fromBrowser
alwaysfalse
to make browser telemetry duplicate in server