Improve ports #440

jeanp413 · 2022-09-21T04:14:03Z

Related issues

Fix gitpod-io/gitpod#8377
Fix gitpod-io/gitpod#11616

How to test

Open this PR in vscode-desktop, compile (run yarn vscode:prepublish in gitpod-remote folder) and launch "Launch gitpod-remote" debug config
Open a workspace with ports configured in gitpod.yml
Check the ports are forwarded when connecting in ports view
Run some command that uses some port
Check the port is forwarded automatically
Check exposed ports webview view is visible and working as expected

extensions/gitpod-remote/src/extension.ts

extensions/gitpod-remote/src/ports.ts

extensions/gitpod-remote/src/machineSettings.ts

jeanp413 · 2022-09-22T04:46:38Z

Seems it won't be possible to add the make public/private inline action as there's no context key we can use it to enable/disabled accordingly

extensions/gitpod-remote/src/extension.ts

akosyakov · 2022-09-22T11:03:07Z

Seems it won't be possible to add the make public/private inline action as there's no context key we can use it to enable/disabled accordingly

because it should be part of item?

jeanp413 · 2022-09-22T14:29:06Z

because it should be part of item?

yeah

extensions/gitpod-shared/portsview/src/utils/commands.ts

jeanp413 · 2022-09-23T15:21:44Z

extensions/gitpod-remote/src/portViewProvider.ts

+
+type PortCommand = typeof PortCommands[number];
+
+export class GitpodPortViewProvider implements vscode.WebviewViewProvider {


Duplicate this for now as it's using configcat code on gitpod-web and migration is almost done, so not worth to move more code I think

@mustard-mh Is it done can we just remove old code with this PR?

akosyakov · 2022-09-26T07:01:48Z

@jeanp413 Is it good? I tried from sources for VS Code Browser and view is empty. It is the same in VS Code Desktop. Let me know when it is good to try.

akosyakov · 2022-09-26T07:09:24Z

extensions/gitpod-web/src/portViewProvider.ts

+
+type PortCommand = typeof PortCommands[number];
+
+export class GitpodPortViewProvider implements vscode.WebviewViewProvider {


I wonder why we cannot move everything to shared, and then pass options for customizations?

There seem to be still quite duplication between remote and web?

jeanp413 · 2022-09-26T16:21:36Z

@akosyakov yeah it works but I forgot to mention how to compile 🤦 , right now is kinda tricky run the yarn compile in extensions folder and then yarn build:webview in gitpod-remote folder, I'll improve the scripts.
For gitpod-web is more tricky to test because webviews don't work out of the box, you'll need to change the webview resources url endpoint manually in workbench.ts

jeanp413 · 2022-09-26T22:56:15Z

Added scripts in gitpod-remote folder:

to compile both webview and extension run yarn vscode:prepublish
to compile only ext run yarn compile
to compile webview run build:webview

mustard-mh · 2022-09-27T18:28:42Z

extensions/gitpod-remote/src/ports.ts

+				const req = new PortsStatusRequest();
+				req.setObserve(true);
+				const evts = context.supervisor.status.portsStatus(req, context.supervisor.metadata);
+				stopUpdates = evts.cancel.bind(evts);


What we use stopUpdates for? like cancelContext in golang?

I just copied this xD, but it will be used in the dispose method to cancel the portsStatus request

extensions/gitpod-remote/src/ports.ts

extensions/gitpod-remote/src/machineSettings.ts

mustard-mh · 2022-09-27T19:11:58Z

I will test it tomorrow

mustard-mh · 2022-09-28T10:02:22Z

Tested it follow the how to test section, desktop vscode works well

VSCode Ports	Gitpod Ports

Also build a preview env to test browser vscode, code build process not broken and ports view works too.

mustard-mh · 2022-09-28T10:13:31Z

extensions/gitpod-remote/package.json

+      "panel": [
+        {
+          "id": "portsView",
+          "title": "Exposed Ports",


non-block: Change it to Gitpod Ports can make it more clear?

No, it does not, ports are not belonging to Gitpod, they are the same ports but in different networks. We should point out to difference in networks. And exposed means exposed on Internet in our docs.

akosyakov · 2022-09-28T10:28:05Z

What about the status bar? Should we show ports there as in browser? What view we should open on click? Can we show a menu to select Forwarded ports or Exposed ports? I think it can be another PR though. This one is already big.

jeanp413 · 2022-09-28T16:54:05Z

I'll merge this then and publish a new gitpod-remote version

What about the status bar? Should we show ports there as in browser?

Personally I don't like the ports in status bar as it can take a lot of space and also seems repetitive as we already have two ports view, but we could add it in another PR if needed

jeanp413 requested a review from akosyakov September 21, 2022 04:14

akosyakov reviewed Sep 21, 2022

View reviewed changes

extensions/gitpod-remote/src/extension.ts Outdated Show resolved Hide resolved

akosyakov reviewed Sep 21, 2022

View reviewed changes

extensions/gitpod-remote/src/ports.ts Outdated Show resolved Hide resolved

akosyakov reviewed Sep 21, 2022

View reviewed changes

extensions/gitpod-remote/src/machineSettings.ts Outdated Show resolved Hide resolved

jeanp413 force-pushed the jp/improve-ports branch from b46911d to 15c4eb0 Compare September 22, 2022 04:45

akosyakov reviewed Sep 22, 2022

View reviewed changes

extensions/gitpod-remote/src/extension.ts Outdated Show resolved Hide resolved

mustard-mh force-pushed the gp-code/main branch from 7364fa1 to a923830 Compare September 22, 2022 13:02

jeanp413 force-pushed the gp-code/main branch from a923830 to 7364fa1 Compare September 22, 2022 14:47

jeanp413 force-pushed the jp/improve-ports branch from b0c789c to a5b0afb Compare September 22, 2022 14:48

jeanp413 force-pushed the gp-code/main branch from 7364fa1 to a923830 Compare September 22, 2022 14:49

akosyakov force-pushed the gp-code/main branch from a923830 to e6eabe6 Compare September 22, 2022 23:11

jeanp413 force-pushed the jp/improve-ports branch from a5b0afb to dabcfa2 Compare September 23, 2022 08:00

jeanp413 commented Sep 23, 2022

View reviewed changes

extensions/gitpod-shared/portsview/src/utils/commands.ts Outdated Show resolved Hide resolved

jeanp413 commented Sep 23, 2022

View reviewed changes

jeanp413 force-pushed the gp-code/main branch from b938b64 to 50d58ee Compare September 24, 2022 17:45

jeanp413 force-pushed the jp/improve-ports branch from 8df8e79 to 2ac83b2 Compare September 25, 2022 00:42

akosyakov reviewed Sep 26, 2022

View reviewed changes

jeanp413 force-pushed the jp/improve-ports branch from 2ac83b2 to 16f0b0a Compare September 26, 2022 16:19

akosyakov force-pushed the gp-code/main branch from 9a1caae to 0d1da69 Compare September 26, 2022 23:13

jeanp413 force-pushed the jp/improve-ports branch from 0e87114 to a03de2c Compare September 27, 2022 16:26

mustard-mh reviewed Sep 27, 2022

View reviewed changes

extensions/gitpod-remote/src/ports.ts Show resolved Hide resolved

mustard-mh reviewed Sep 27, 2022

View reviewed changes

extensions/gitpod-remote/src/ports.ts Show resolved Hide resolved

mustard-mh reviewed Sep 27, 2022

View reviewed changes

extensions/gitpod-remote/src/ports.ts Show resolved Hide resolved

mustard-mh reviewed Sep 27, 2022

View reviewed changes

extensions/gitpod-remote/src/machineSettings.ts Show resolved Hide resolved

jeanp413 force-pushed the gp-code/main branch from 0d1da69 to 4e75e18 Compare September 28, 2022 05:08

mustard-mh force-pushed the jp/improve-ports branch from 6ccc915 to cfa9f0e Compare September 28, 2022 06:07

mustard-mh approved these changes Sep 28, 2022

View reviewed changes

mustard-mh reviewed Sep 28, 2022

View reviewed changes

Improve ports

a6b21bd

jeanp413 force-pushed the jp/improve-ports branch from cfa9f0e to a6b21bd Compare September 28, 2022 17:06

jeanp413 merged commit 5708dcc into gp-code/main Sep 28, 2022

jeanp413 deleted the jp/improve-ports branch September 28, 2022 17:07


		type PortCommand = typeof PortCommands[number];

		export class GitpodPortViewProvider implements vscode.WebviewViewProvider {

Improve ports #440

Improve ports #440

Uh oh!

Conversation

jeanp413 commented Sep 21, 2022 • edited by loujaybee Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues

How to test

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeanp413 commented Sep 22, 2022

Uh oh!

Uh oh!

akosyakov commented Sep 22, 2022

Uh oh!

jeanp413 commented Sep 22, 2022

Uh oh!

Uh oh!

jeanp413 Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

akosyakov Sep 26, 2022

Choose a reason for hiding this comment

Uh oh!

akosyakov commented Sep 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akosyakov Sep 26, 2022

Choose a reason for hiding this comment

Uh oh!

jeanp413 commented Sep 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeanp413 commented Sep 26, 2022

Uh oh!

mustard-mh Sep 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeanp413 Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mustard-mh commented Sep 27, 2022

Uh oh!

mustard-mh commented Sep 28, 2022

Uh oh!

mustard-mh Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akosyakov Sep 28, 2022

Choose a reason for hiding this comment

Uh oh!

akosyakov commented Sep 28, 2022

Uh oh!

jeanp413 commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jeanp413 commented Sep 21, 2022 •

edited by loujaybee

Loading

akosyakov commented Sep 26, 2022 •

edited

Loading

jeanp413 commented Sep 26, 2022 •

edited

Loading

mustard-mh Sep 27, 2022 •

edited

Loading

mustard-mh Sep 28, 2022 •

edited

Loading

jeanp413 commented Sep 28, 2022 •

edited

Loading