-
Notifications
You must be signed in to change notification settings - Fork 327
feat: make user aware of the current workspace-image #945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 @axonasif thanks for sharing, we really appreciate your effort with Could I ask some favors?
Why?
Referring back to the epic this is related to, I like the idea of option 2 (improving docs), because as a 🛹 we could improve documentation and readme content, to help improve the user experience. A benefit of this would be that (1) we're not adding complexity to edit: don't get me wrong, this PR is 🦸 🍬 , it'd be great to socialize next steps, which'll help us be mindful of engineering resources and the user experience. |
printf '' > "$lockfile" | ||
|
||
# The supervisor creates the task terminals, supervisor calls BASH from `/bin/bash` instead of the realpath `/usr/bin/bash` | ||
# So we will only print the info once, on a non-task terminal that the user created manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@axonasif as an alternative, it would be nice if this output were visible in a separate (exclusive) task terminal, avoiding user opened terminals altogether. In other words, then, they could always "reference it", by simplying looking at it, without having to ever opt-out.
Another thought is, we persist this output somewhere in /workspace
, and then link to it from the Gitpod menu "in workspace". In other words, never present this content in a Terminal.
☝️ are example thoughts that would be best to socialize as feedback in a RFC. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is good idea to have one task terminal which shows such info. I also like idea of doing it in supervisor only for regular workspaces if we would like generally welcome a user. In this case though we need to check somehow whether it is default image or not.
Would it pop up in each terminal? |
Hey @akosyakov, it will be printed once for a user created terminal. |
Not for supervisor task terminals right? |
Right. It won't show on them. |
Description
.gitpod.yml
and the dockerfile if-exists)README.md
GITPOD_DISABLE_WORKSPACE_IMAGE_INFO=true
at https://gitpod.io/variables with*/*
as the scope.Related Issue(s)
Relates with gitpod-io/gitpod#10683
Next steps:
chunk/*/
dir explaining what this chunk contains and if there's something special to be aware of.base/
dir to explain how the base image sets up the required things for a minimal but functional docker image. In case someone wants to create their own minimal base image of a different distro (i.e Arch or Fedora)So that the user can click the scoped link from their terminal to read these READMEs
How to test
docker build -t base base/ && docker run -v /workspace:/workspace -e GITPOD_REPO_ROOT -e GITPOD_GIT_USER_NAME -it base
image
values on.gitpod.yml
and rerun the above command to get different info. Or you can remove.gitpod.yml
and it will assume the default image, which isworkspace-full
. You may change the image name on.gitpod.Dockerfile
as well.Release Notes
Documentation