Skip to content

diff on rename misleading #1924

@extrawurst

Description

@extrawurst
Collaborator

right now a rename-diff looks like a huge delete-everything and add-everything:

Screenshot 2023-10-16 at 18 02 58

Activity

added this to the v0.25 milestone on Oct 16, 2023
extrawurst

extrawurst commented on Feb 19, 2024

@extrawurst
CollaboratorAuthor

work in progress in branch rename-detection

modified the milestones: v0.25, v0.26 on Feb 19, 2024
modified the milestones: v0.26, v0.27 on Apr 14, 2024
modified the milestones: v0.27, v0.28 on Jan 13, 2025
naseschwarz

naseschwarz commented on Mar 31, 2025

@naseschwarz
Contributor

Could you please elaborate on your expectation here, @extrawurst? Something akin to how git log displays renames?

Image

extrawurst

extrawurst commented on Apr 1, 2025

@extrawurst
CollaboratorAuthor

This particular issue is only about showing the content diff correctly, so that the file content diff looks like it looks if you did not also rename the file at the same time. hope that makes more sense.

examples:

  • if nothing changed inside of the file: empty diff (maybe mark it in the header that its a pure rename)
  • if its a rename that changed one inside the file aswell: lets show that diff only, like it would if the filename was not also changed at the same time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @extrawurst@naseschwarz

        Issue actions

          diff on rename misleading · Issue #1924 · gitui-org/gitui