Skip to content

Fix xy_coords size mismatch #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Fix xy_coords size mismatch #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions stackstac/prepare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,24 +389,10 @@ def to_coords(
maxy + half_ypixel,
)

# NumPy arange produces `ceil((stop - start)/step)` elements, whereas GDAL rounds (more or less).
# This, combined with floating-point error, can make our coordinates off-by-one in length,
# so we add/remove pixels to `maxx`, `maxy` as necessary to ensure the coordinates end up the same
# size as the array.
height, width = spec.shape
coord_width = np.ceil((maxx - minx) / xres)
extra_width = coord_width - width
if extra_width:
maxx -= xres * extra_width

coord_height = np.ceil((maxy - miny) / yres)
extra_height = coord_height - height
if extra_height:
maxy -= yres * extra_height

# Wish pandas had an RangeIndex that supported floats...
xs = pd.Float64Index(np.arange(minx, maxx, xres))
ys = pd.Float64Index(np.arange(maxy, miny, -yres))
xs = pd.Float64Index(np.linspace(minx, maxx, width, endpoint=False))
ys = pd.Float64Index(np.linspace(maxy, miny, height, endpoint=False))
else:
height, width = spec.shape
if pixel_center:
Expand Down