Update AddHostKey to avoid always appending #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be a test that's hanging only in CI... so I'll have to look into that. |
|
Ok, I rewrote TestSignals - I couldn't get t.Fatal to work from inside a goroutine, so I passed errors out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it mentions in the comment, this is based on the code from x/crypto/ssh and is done to optimize dynamically loading keys at runtime (to avoid keeping old keys around). I've been experimenting and I would have just done it with the config callback, but it seems like there's not a great way to do this (since we auto-generate a key if there are none, and always add the HostSigners to the server config).
The config at runtime has a number of race conditions still present (they mostly happen if you set an option at runtime directly) but the one for AddHostKey should be fixed.