Don't fire the callback when cleanup is in progress #4527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: gluster#4525 Change-Id: I8264d21fb285a870adead71015f1fc87a4b375ab Signed-off-by: Pranith Kumar Karampuri <[email protected]>
|
The issue seems to be that there is a lag between setting ctx->cleanup_started and setting reg->fin in timer, so by the time the event callback is triggered conn was already freed. |
|
@pranithk I see you marked it as Draft, does that mean it is still a work in progress? Do you want me to review this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4525
Change-Id: I8264d21fb285a870adead71015f1fc87a4b375ab