elementwise_op: use 2d loop for Array #1223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Array linear indexing is not the same as Matrix linear indexing. Fixes #1222.
This was referenced Sep 2, 2022
alexvong243f
reviewed
Sep 4, 2022
Comment on lines
-244
to
246
| def make_matrix_or_array(ls_of_ls, dbg_no_array=True): | ||
| def make_matrix_or_array(ls_of_ls, dbg_no_array=False): | ||
| # should be kept in sync with the same function | ||
| # defined in inst/private/python_ipc_native.m |
There was a problem hiding this comment.
I think we should also change dbg_no_array from True to False in inst/private/python_ipc_native.m.
LGTM otherwise as this test (for @sym/and)
%!test
%! % array
%! w = [t t f f];
%! z = [t f t f];
%! assert (isequal (w & z, [t f f f]))
now passes!
...with 'inst/private/python_header.py'. Follow-up to 56bd719. * inst/private/python_ipc_native.m: Disable it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array linear indexing is not the same as Matrix linear indexing.
Fixes #1222.