feat(NSFileHandle): Add new APIs with error handling, and refactor GSFileHandle #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple deprecated a significant part of the NSFileHandle API in favour of new methods that write out errors instead of throwing an exception. This is likely due to interoperability with Swift.
Implements new private methods to correctly implement the new set of APIs that return errors instead of exceptions.
Length was previously unsigned int, but is NSUInteger in Apple's implementation.
|
hmmh seems like the CI is broken again... |
|
Seems like libdispatch master is currently broken swiftlang/swift-corelibs-libdispatch#880 |
|
This looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of Apple's ongoing improvements for interoperability between Swift and Foundation, a significant part of NSFileHandle was deprecated in favour of methods that write out errors.
This pull request implements the following new APIs:
Refactors GSFileHandle to return errors in private helper methods, and fixes some declaration differences between Apple's Foundation and GNUstep.