Skip to content

Some fixes and QoL improvements #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 21, 2019
Merged

Some fixes and QoL improvements #45

merged 18 commits into from
May 21, 2019

Conversation

estutzenberger
Copy link

This PR includes:

  • Fixes for HCI flow control behavior
  • Race condition during connections
  • For HCI timeout when device does not respond
  • Adds ability to configure connection and scan parameters

jlassahnrigado and others added 18 commits February 6, 2019 11:33
@jlassahnrigado
Made Command Flow Control match the actual behavior specified in
a9b3590 
the Bluetooth spec (Vol 2, Part E, Section 4.4), old version tended to
collect extra allowed commands over time and eventually lock up.
@jlassahnrigado
comments on magic numbers
0427615
@estutzenberger
Merge pull request #1 from rigado/fix/flowcontrol
f5f249d 
Make flow control work
@jlassahnrigado
add options for setting scanning and advertising parameters.
33ae558
@estutzenberger
Merge pull request #2 from rigado/feature/options
3b8c738 
Add options for setting scanning and advertising parameters.
@jlassahnrigado
Close the socket if device intialization fails.
b3fe2e9
@estutzenberger
Merge pull request #3 from rigado/fix/init_error
0dba3c0 
Clean up if device intialization fails.
@jlassahnrigado
Fix race condition where new data can be written to a connection whil…
19fcd8a 
…e it

is being disconnected, and the buffers are leaked from the packet pool
forever.
@jlassahnrigado
Fix typo in comment.
579de92
@estutzenberger
Merge pull request #4 from rigado/fix/race_on_disconnect
53fc7ac 
Fix race condition on disconnect
@jlassahnrigado
Prevent HCI send from blocking forever if the device doesn't respond.
7627da4
@jlassahnrigado
clear sent table when a reply is received so unexpected packets don't…
ad9bd85 
… cause

random weirdness.
@jlassahnrigado
Avoid receiving invalid command response on device stop.
5c64eb9
@estutzenberger
Merge pull request #5 from rigado/fix/failed_send
fd3e6c7 
Emergency timeout for failed HCI sends
@estutzenberger
Update readme (#12)
99cb472 
* Update with disclaimer
@estutzenberger
update README
460c6f7
@estutzenberger
update README
c8a4f62
@estutzenberger
Merge branch 'master' into pull-request-to-main-repo
b28219d
@estutzenberger estutzenberger merged commit 147700f into go-ble:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estutzenberger @jlassahnrigado