hci: add Connect/DisconnectHandler options #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I have only recently taken over management of this library so some of the code is still new to me. I think this generally looks fine. For #49, I think the better fix is to only re-enable advertising upon disconnection. A completed connection should not re-enable advertising since only one central connection is allowed. Note that the spec allows for multiple central connections but as far as I have seen, this is not well supported or often used. |
linux/hci/hci.go
Outdated
| @@ -505,6 +509,10 @@ func (h *HCI) handleLEConnectionComplete(b []byte) error { | |||
| } | |||
| h.params.RUnlock() | |||
| } | |||
| log.Println("incoming:", c.RemoteAddr()) | |||
There was a problem hiding this comment.
Please remove this log message. I think the library generally needs a logging pass.
estutzenberger
approved these changes
Jan 10, 2020
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #48