Skip to content

Feature/key events #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2019
Merged

Feature/key events #140

merged 1 commit into from
May 21, 2019

Conversation

pchampio
Copy link
Member

@pchampio pchampio commented May 18, 2019 •
edited
Loading

First draft of RawKeyboard events support. Only supporting the Android Keymap (and there is a major workaround), consider this as a preview feature.

fixes #136, we'll need new issue/PR to address the workaround.

@pchampio pchampio added the embedder Issue concerns the embedder package label May 18, 2019
@pchampio pchampio requested a review from GeertJohan May 18, 2019 00:32
@pchampio pchampio mentioned this pull request May 18, 2019
Closed
@pchampio pchampio force-pushed the feature/key-events branch 2 times, most recently from 7317800 to df9e57f Compare May 18, 2019 00:47
@pchampio pchampio added the enhancement New feature or request label May 18, 2019
GeertJohan
GeertJohan reviewed May 18, 2019
View reviewed changes
@GeertJohan
Copy link
Member

Great feature! Some small suggestions but the rest looks good to add as experimental feature. Perhaps add a bit to the README about how this is still experimental and what is/is not supported.

@pchampio pchampio force-pushed the feature/key-events branch 2 times, most recently from 3f44fbb to a747735 Compare May 19, 2019 21:07
@pchampio
Copy link
Member Author

GLFW's keyCodes are natively supported by the Flutter framework.
go-flutter only supports RawKeyEventDataLinux RawKeyEventData because the linux implementation is the only one to support the GLFW window toolkit.

Only keyDown & keyUp events are supported by the flutter framework, go-flutter matchs the same configuration.

Dart Code to test the feature

@pchampio pchampio requested a review from GeertJohan May 19, 2019 21:19
GeertJohan
GeertJohan reviewed May 20, 2019
View reviewed changes
Copy link
Member

@GeertJohan GeertJohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One spelling mistake in a comment and a remark about the textChannel name. Maybe those changes can be applied before merging! Otherwise looks good to merge! 🎉

feature: support for RawKeyboard events
b7e982a 
Uses the the RawKeyEventDataLinux for every platform.
RawKeyEventDataLinux is the only Flutter implementation that support the
GLFW Toolkit, the events data is sended as it is, no translation is made
in go-flutter, everything is handled by the Flutter framework.
@pchampio pchampio force-pushed the feature/key-events branch from a747735 to b7e982a Compare May 20, 2019 18:55
@pchampio pchampio requested a review from GeertJohan May 20, 2019 18:57
@pchampio
Copy link
Member Author

pchampio commented May 20, 2019 •
edited
Loading

Changes applied!
PTAL

@GeertJohan GeertJohan merged commit dc64686 into master May 21, 2019
@GeertJohan GeertJohan deleted the feature/key-events branch May 21, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeertJohan GeertJohan GeertJohan approved these changes

Assignees
No one assigned
Labels
embedder Issue concerns the embedder package enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RawKeyboard events support
2 participants
@pchampio @GeertJohan