Feature/event loop interop #215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes #198 * fixe weird edge case
The crash might be related to the golang wrapper of GL
need to implement Unregister, need to exposes: MarkExternalTextureFrameAvailable, RegisterExternalTexture in a good looking api
TODO: destroy the gl.GenTextures
pchampio
force-pushed
the
feature/event-loop-interop
branch
from
dd2dcf4 to
99584e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will have to be re-based to master once feature/gl_texture gets merged.
Go implementation of https://github.com/flutter/engine/pull/9089/files
This feature is removing a deprecated engine function. For now, there is a tiny benefit of using
FlutterCustomTaskRunners, instead ofFlutterEngineFlushPendingTasksNow.Once the restriction evoked by @chinmaygarde comment is lift. I hope to remove all polling handler from the embedder.