Select opengl #258
Merged
Select opengl #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchampio
added a commit
to go-flutter-desktop/hover
that referenced
this pull request
Sep 12, 2019
read the matching go-flutter PR: go-flutter-desktop/go-flutter#258
pchampio
force-pushed
the
select_opengl
branch
from
1276cc2 to
78dcd14
Compare
pchampio
force-pushed
the
select_opengl
branch
2 times, most recently
from
a882e19 to
e8047c5
Compare
wraps the go-gl/gl lib in a internal package with build constrains to let the user choose which go-gl/gl version he desire. support 3.3(default) and none. When the build tag is set to none, no dependency to go-gl/gl is required, but texture plugins will not be supported.
pchampio
force-pushed
the
select_opengl
branch
from
e8047c5 to
f3ccad5
Compare
GeertJohan
reviewed
Sep 20, 2019
|
One question, otherwise LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select the OpenGL version to use.
wraps the go-gl/gl lib in a internal package with build constrains to
let the user choose which go-gl/gl version he desire.
support 3.3(default) and none.
When the build tag is set to none, no dependency to go-gl/gl is
required, but texture plugins will not be supported.
related hover PR: go-flutter-desktop/hover#24