Skip to content

Add config file #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2019
Merged

Add config file #51

merged 1 commit into from
Oct 21, 2019

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Oct 20, 2019 •
edited
Loading

Adds a config file for permanently setting variables like target or branch:

target: lib/main_desktop.dart
# Change to "@latest" to download the latest go-flutter version on every build:
branch: ""
# https://github.com/go-flutter-desktop/go-flutter/issues/184:
# cache-path: "/home/YOURUSERNAME/.cache/"
# Uncomment this line if you have trouble with your OpenGL driver (https://github.com/go-flutter-desktop/go-flutter/issues/272):
# opengl: "none"
docker: false

@pchampio
Copy link
Member

Having a written configuration file for hover is interesting.
I like it.
But, we agreed with @GeertJohan to interfere as less as possible with the flutter toolchain.
Currently everything related to hover/go-flutter is located under the go directory which makes go-flutter easily removable from any flutter project. (The flutter team is doing an awesome job, we don't want to ruin it^^)

The OPTIONAL config block/variables can be located under a go/hover.yaml file.

@pchampio pchampio self-requested a review October 20, 2019 21:57
pchampio
pchampio requested changes Oct 20, 2019
View reviewed changes
Copy link
Member

@pchampio pchampio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OPTIONAL config block/variables should be located elsewhere

pchampio
pchampio reviewed Oct 20, 2019
View reviewed changes
pchampio
pchampio reviewed Oct 20, 2019
View reviewed changes
pchampio
pchampio reviewed Oct 20, 2019
View reviewed changes
@provokateurin provokateurin changed the title Add config block to pubspec.yaml Add config file Oct 21, 2019
pchampio
pchampio requested changes Oct 21, 2019
View reviewed changes
@pchampio pchampio self-requested a review October 21, 2019 10:53
pchampio
pchampio approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@pchampio pchampio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uses of hover.yaml is very interesting, I look forward to add more and more feature into it.

LGTM.

@provokateurin
Copy link
Member Author

I need it mostly, because I was annoyed by using -t lib/main.dart every time

@provokateurin provokateurin merged commit 2708c8c into go-flutter-desktop:master Oct 21, 2019
@provokateurin provokateurin deleted the feature/config branch October 21, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchampio pchampio pchampio approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@provokateurin @pchampio