Skip to content

Remove/Replace custom version of semantic dropdown #10672

Closed
@silverwind

Description

@silverwind
Member

Remove it and use proper API instead as outlined in fomantic/Fomantic-UI#1332 (comment).

Activity

silverwind

silverwind commented on Mar 8, 2020

@silverwind
MemberAuthor

Alternative: Just remove it and wait on Fomantic to provide the a11y hints eventually (My favorite).

changed the title [-]Replace custom version of semantic dropdown[/-] [+]Remove/Replace custom version of semantic dropdown[/+] on Mar 8, 2020
stale

stale commented on May 7, 2020

@stale

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

added
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implemented
on May 7, 2020
Flameborn

Flameborn commented on May 19, 2020

@Flameborn

Removing this and waiting for Fomantic to implement it upstream would mean that Gitea's dropdowns are going to break for screen reader users.

If you choose to do this, and I hope you don't until Fomantic implements it, you should mention it in the changelog to warn existing screen reader users, of which there are quite a few at the moment.

zeripath

zeripath commented on May 19, 2020

@zeripath
Contributor

So unfortunately I think that this piece of code may be attempting to do too much. If we can restructure it to not require so much insertion to fomantics code that would be much better - even if it requires us to set extra attributes in our templates that's still better.

Can anyone get fomantic/Fomantic-UI#1332 to just work for a very simple page?

As with everything we need to split things down into simple steps.

Jookia

Jookia commented on May 19, 2020

@Jookia
Contributor

I don't want to sound salty but I provided a patch series implementing dropdown accessibility in simple steps when I originally added the code. As for whether it's too much, it doesn't implement half the functionality needed for drop down accessibility given the wide variety of widgets Gitea uses.

I feel quite confident saying that you cannot implement accessible dropdowns using that API they've provided, and perhaps not with Fomantic at all. To implement ARIA support you need a concept of widgets which Fomantic lacks, instead it ships low-level components that you compose together in various ways in HTML.

zeripath

zeripath commented on May 19, 2020

@zeripath
Contributor

@Jookia - I never intended to dismiss your work. My only worry is that it walks the DOM and recreates things in a way that potentially breaks.

I've spent hours trying to get orca to work and failed. I've tried to find any information on what needs to change to make this work and have failed.

It must be possible to make dropdowns work properly. Can anyone just give us an example of something that actually works?

Jookia

Jookia commented on May 20, 2020

@Jookia
Contributor
Flameborn

Flameborn commented on May 20, 2020

@Flameborn
Jookia

Jookia commented on May 20, 2020

@Jookia
Contributor

23 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedtopic/uiChange the appearance of the Gitea UI

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @silverwind@techknowlogick@Jookia@Flameborn@zeripath

      Issue actions

        Remove/Replace custom version of semantic dropdown · Issue #10672 · go-gitea/gitea