Closed
Description
- Gitea version (or commit ref): 1.1.0+5-gdbcd4527
- Git version: 2.12.0
- Operating system: Linux/CentOS7
- Database (use
[x]
):- PostgreSQLMySQLMSSQLSQLite
- Can you reproduce the bug at https://try.gitea.io:
- Log gist:
[...uters/repo/commit.go:92 Graph()] [E] GetCommitGraph: Failed parsing grap line:* DATA:||... - Should containt 8 datafields
Description
steps to reproduce:
touch dummyfile
git add dummyfile
git commit -m "this is a testcommit | containing a pipe"
git push
# view commitgraph
In models/graph.go
in GetCommitGraph(r *git.Repository) (GraphItems, error)
calls a git log
and uses a custom format using pipes as field separators. Later in graphItemFromString(s string, r *git.Repository) (GraphItem, error)
the lines get split by that delimiter and the resulting array is being checked whether or not it has exactly 8 elements.
The easiest solution would be to check whether or not the array has at least 8 elements and merge the 8th to nth elements together.
Metadata
Metadata
Assignees
Type
Projects
Relationships
Development
No branches or pull requests
Activity
fix #1189, commit messages containing a pipe (#1218)
fix go-gitea#1189, commit messages containing a pipe (go-gitea#1218)