Skip to content

Incorrect "merged by" value in pull requests list #13260

Closed
@lakostin

Description

@lakostin
  • Gitea version (or commit ref):
    1.14.0+dev-18-gd453533be
  • Git version:
    2.26.2
  • Operating system:
    docker Alpine Linux
  • Database (use [x]):
    • PostgreSQL
      MySQL
      MSSQL
      SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
      No
  • Log gist:

Screenshots

Screenshot from 2020-10-21 18-17-42
Screenshot from 2020-10-21 18-17-55

Activity

zeripath

zeripath commented on Oct 22, 2020

@zeripath
Contributor

One is likely to be the person who opened the PR and one is the person who merged the PR.

lakostin

lakostin commented on Oct 22, 2020

@lakostin
Author

the problem is that it's written "merged by %person who opened pull request%"
but actually other person merged it

zeripath

zeripath commented on Oct 22, 2020

@zeripath
Contributor

So it's not an incorrect value but rather that the label is unclear. The pulls list has to have the pr author on it - the person who merged it is irrelevant.

The string should be changed to be:

by andrei.kirin merged 11 minutes ago

added
topic/uiChange the appearance of the Gitea UI
on Oct 22, 2020
lakostin

lakostin commented on Oct 22, 2020

@lakostin
Author

i would use this variant which is much more clear in my opinion:
opened by andrey.kirin; merged 11 minutes ago by anton.kostin

added a commit that references this issue on Oct 23, 2020
1501a10
added a commit that references this issue on Oct 24, 2020
0800c7e
locked and limited conversation to collaborators on Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    topic/uiChange the appearance of the Gitea UI

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @lunny@zeripath@lakostin

      Issue actions

        Incorrect "merged by" value in pull requests list · Issue #13260 · go-gitea/gitea