Skip to content

Performance regression in Gitea 1.14 for large diffs #16130

Closed
@jpraet

Description

@jpraet
Member
  • Gitea version (or commit ref): 1.14.2
  • Operating system: docker on RHEL 7.7

Due to #13949 when you want to create a PR for backporting a change to a release branch, gitea first calculates the diff against the master branch. If the branches have diverged a lot this diff can be quite large, and the processing and rendering can take a very long time. This was already quite slow on Gitea 1.13, but on Gitea 1.14 it got significantly slower.

Gitea 1.14.2:
2021/06/09 16:28:03 Completed GET /CBSS/cics/compare/master...release/10.2 200 OK in 2m15.325931649s

Same with Gitea 1.13.4:
2021-06-09 16:04:19: Completed GET /CBSS/cics/compare/master...release/10.2 200 OK in 46.343604847s

It looks like the performance has already improved again on the latest 1.15 dev version:
2021/06/10 16:00:08 Completed GET /CBSS/cics/compare/master...release/10.2 200 OK in 34.828378582s

This diff is pretty large: 375 changed files with 22643 additions and 25134 deletions.

I noticed there are other tickets about performance issues with 1.14, but they seem to be related to Windows, or to repo browsing.

Activity

jpraet

jpraet commented on Jun 10, 2021

@jpraet
MemberAuthor

I will try to identify the commit that improved the performance on 1.15.

jpraet

jpraet commented on Jun 10, 2021

@jpraet
MemberAuthor

It's #15667. Could it be backported to 1.14? /cc @zeripath

wxiaoguang

wxiaoguang commented on Apr 16, 2022

@wxiaoguang
Contributor

Outdated

locked and limited conversation to collaborators on May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    performance/speedperformance issues with slow downs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @lunny@wxiaoguang@jpraet

        Issue actions

          Performance regression in Gitea 1.14 for large diffs · Issue #16130 · go-gitea/gitea