Skip to content

A large white box obstructs the file editor on iOS #16188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 6 tasks
jacopo-j opened this issue Jun 17, 2021 · 14 comments · Fixed by #24341
Closed
2 of 6 tasks

A large white box obstructs the file editor on iOS #16188

jacopo-j opened this issue Jun 17, 2021 · 14 comments · Fixed by #24341
Labels
topic/mobile topic/ui Change the appearance of the Gitea UI type/bug

Comments

@jacopo-j
Copy link

  • Gitea version (or commit ref): 1.14.2, from your releases
  • Git version: 2.30.1
  • Operating system: macOS 11.3, running from launchd
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (any file editing page)
    • No
  • Log gist:

Shouldn't be relevant (it's a UI problem)

Description

Title and screenshots are pretty self-explanatory. They were taken on an iPhone and on an iPad both running iOS 14.6 and using Safari. The problem doesn't occur on Safari on macOS.

Screenshots

IMG_2126
IMG_0270

@silverwind
Copy link
Member

Can you check if that box is also there on https://microsoft.github.io/monaco-editor/playground.html?

@jacopo-j
Copy link
Author

Doesn't seem so:
IMG_0271

@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Jun 19, 2021
@thoppa
Copy link

thoppa commented Apr 24, 2022

Same issue- prevents editing of last 10ish lines of code. I have been adding 10 ish blank lines.

@silverwind
Copy link
Member

Still present in latest Safari?

@jacopo-j
Copy link
Author

Yes

@silverwind
Copy link
Member

Please hook up web inspector to the phone, inspect the element and show the HTML.

@jacopo-j
Copy link
Author

Looks like element <textarea class="iPadShowKeyboard"> is the culprit

Screenshot 2023-04-22 alle 18 32 47

@silverwind
Copy link
Member

silverwind commented Apr 22, 2023

Interesting, this textarea seems like something that Safari itself adds to the page, or maybe an extension? Do you run any Safari extensions?

@silverwind
Copy link
Member

silverwind commented Apr 22, 2023

@silverwind
Copy link
Member

The monaco issue tracker does not yield any results for this issue, so I assume it must be our CSS interfering with this feature of VSCode/Monaco.

@jacopo-j one last question: if you add display: none !important to the element's CSS in the inspector, does the editor work normally, or do you see reduced functionality?

@jacopo-j
Copy link
Author

It does seem to work normally.

@silverwind
Copy link
Member

Okay I guess I will add that as a workaround then, but leaving this open for the future for a proper fix.

@silverwind
Copy link
Member

I think I found out what this textarea may supposed to be. See bottom-right:

image

So it seems to be some kind of accessiblity helper that should bring up the native browser textarea, but I suppose this is mostly unnecessary.

@silverwind
Copy link
Member

Will check if i can debug this in XCode's IOS simulator.

silverwind added a commit that referenced this issue Apr 26, 2023
Fix #16188. Turns out the
element was completely misaligned by fomantic styles. Add most of the
original styles in `!important` form to fix.

Tapping the button doesn't do anything useful in Simulator.app, but I
guess it's still better to not outright hide it in case it has a
possiblity to work.

<img width="121" alt="image"
src="https://user-images.githubusercontent.com/115237/234379685-4e67f8cd-7e91-4bcc-8e17-9d5b2ebed6cd.png">

Co-authored-by: Giteabot <[email protected]>
GiteaBot added a commit to GiteaBot/gitea that referenced this issue Apr 26, 2023
Fix go-gitea#16188. Turns out the
element was completely misaligned by fomantic styles. Add most of the
original styles in `!important` form to fix.

Tapping the button doesn't do anything useful in Simulator.app, but I
guess it's still better to not outright hide it in case it has a
possiblity to work.

<img width="121" alt="image"
src="https://user-images.githubusercontent.com/115237/234379685-4e67f8cd-7e91-4bcc-8e17-9d5b2ebed6cd.png">

Co-authored-by: Giteabot <[email protected]>
silverwind added a commit that referenced this issue Apr 26, 2023
Backport #24341 by @silverwind

Fix #16188. Turns out the
element was completely misaligned by fomantic styles. Add most of the
original styles in `!important` form to fix.

Tapping the button doesn't do anything useful in Simulator.app, but I
guess it's still better to not outright hide it in case it has a
possiblity to work.

<img width="121" alt="image"
src="https://user-images.githubusercontent.com/115237/234379685-4e67f8cd-7e91-4bcc-8e17-9d5b2ebed6cd.png">

Co-authored-by: silverwind <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/mobile topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants