-
-
Notifications
You must be signed in to change notification settings - Fork 6k
Closed
Closed
Copy link
Description
- Gitea version (or commit ref): 1.15.0+dev-578-g8464fa15d
- Git version:
- Operating system: official docker
- Database (use
[x]
):- PostgreSQLMySQLMSSQLSQLiteTo pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
- Can you reproduce the bug at https://try.gitea.io:
- Yes (You edit a file commit it, this behavior will not show up in the dashboard, and if you have webhook, it will not trigger)NoTo pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
- Log gist:
Sorry, but I dont see any error/abnormals in logs of gitea.
Description
I upgraded my gitea image to the latest version in dockerhub.
And the webhook no longer works, I found that my git push activities are not presenting in my dashboard.
Looks like the new version gitea totally missed my git push activities.
Action
You push a commit to a repo.
Expected
-
The webhook of this repo will be triggered by this push
Actual
- You can see your commit in the source code page
- But your commit does not show up in the dashboard
- The webhook is not triggered
Below is my recordings about that, all I test is to push a commit into the repo, and expect this action to be shown in the dashboad, and demostrate that it works in the older version, and not working in the newest one
Screenshots
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
zeripath commentedon Jul 14, 2021
I'm likely being completely dense but I can't for the life of me understand what it is that is not happening when it should and what it is that you're trying to do.
The videos are not that helpful by themselves. Please describe what it is you are doing.
[-]In 1.15.0, git push activites does not work, webhoot on push not work[/-][+][BUG] In 1.15.0, git push activites does not work, webhoot on push not work[/+]duchenpaul commentedon Jul 14, 2021
Sorry for the inconvinience, I expanded more details about the issue, if you have any questions, please let me know
lunny commentedon Jul 14, 2021
I cannot reproduce this on my local macOS Gitea instance.
zeripath commentedon Jul 14, 2021
I suspect that you need to resynchronize the hooks.
Also ensure that your repositories are not being mounted as noexec
zeripath commentedon Jul 14, 2021
Your browser is obscuring the most important part of the logs too. When you make the push there should be a call to:
api/internal/hook/pre-receive/:owner/:repo
andapi/internal/hook/post-receive/:owner/:repo
if that's not there then it's clear that your hooks aren't either being run or are being sent to the wrong place.
duchenpaul commentedon Jul 15, 2021
Take a step back, on https://try.gitea.io,

when you push a change, there should be an update to the dashboard, saying
:username pushed to :branch_name at :repo_name
, like so:I just tried to do so in https://try.gitea.io, there is no such update on my dashboard.
The url is here: https://try.gitea.io/duchenpaul/Hosted
You can see the last commit is

Thu, 15 Jul 2021 00:17:11 UTC
if you go to my profile, the last update is

Wed, 14 Jul 2021 15:52:44 UTC
, which the time when the repo was forks, not get updated by my push.duchenpaul commentedon Jul 15, 2021
In order to reproduce, please:
Recent Deliveries
to see if it is triggeredmulticast commentedon Jul 15, 2021
I can confirm; I have the same behavior in 1.15.0+dev-582-g3dcb3e907
Creating a new repository via UI, copy/paste initial commands and pushing README to master, and UI never shows code, but the introductory message. I veriefied that the data are actually pushed and the bare repository has the "first commit" pushed, but web-UI still displays hint on how to add origin or make first commit.
duchenpaul commentedon Jul 15, 2021
@multicast yeah, if you use webhook, it won't trigger
multicast commentedon Jul 15, 2021
@duchenpaul no, create repo, git init/touch/add...push, and the repo on the web looks like no push happened. but repositories/user/name.git does contain the commit. there is no special webhook added yet to newly created repo yet.
Xenolphthalein commentedon Jul 15, 2021
I can reproduce this issue with a newly created docker instance on 1.15.0 (latest).
If you revert to 1.14.4 everything works as expected.
multicast commentedon Jul 15, 2021
I was now on the same journey and confirm :latest tag is buggy and :1.14.4 works.
The database version has been bumped since 1.14.4 several times, what issues I can expect when looking at models/migrations/v178 ... 188.go?
[-][BUG] In 1.15.0, git push activites does not work, webhoot on push not work[/-][+][BUG] In 1.15.0, git push activites does not work, webhook on push not work[/+]zeripath commentedon Jul 15, 2021
I just did this and could not reproduce.
8 remaining items
zeripath commentedon Jul 15, 2021
I've just tried the compose route: (
docker-compose version 1.29.2, build 5becea4c
on1.15.0+dev-582-g3dcb3e907
and still can't reproduce this.docker-compose.yml
app.ini
`docker version`
I'm really confused as to what is going on here.
zeripath commentedon Jul 15, 2021
But I can see that try.gitea.io isn't working! For both http and ssh pushing.
techknowlogick commentedon Jul 15, 2021
This is `docker version` info from try
Sooo... this means if we stick with alpine 3.14 then we need to note the minimum version of docker required. Here are minimum requirements: https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0#faccessat2
zeripath commentedon Jul 16, 2021
So... it is the alpine 3.14 PR then and it was a capabilities/permissions issue.
I think we probably have to revert the alpine 3.14 PR - and move that to later in 1.16. Then we can deprecate docker 19 this cycle and make the break in 1.16.
techknowlogick commentedon Jul 16, 2021
@zeripath yeah :( That's probably the best direction. I'll send the PRs
zeripath commentedon Jul 16, 2021
whilst you're at it you could approve the three PRs I just dropped fixing some of my own earlier stupidity!
techknowlogick commentedon Jul 16, 2021
I mean, others missed it too, so... but this was an easy thing to miss so I wouldn't beat yourself up over it.
techknowlogick commentedon Jul 16, 2021
PR sent. thanks to everyone who reported this issue and for providing detailed follow up information so we could trace where this was happening.