It is possible to reopen merged PRs via API

[qwerty287]

Gitea Version

(almost) latest main

Git Version

No response

Operating System

No response

How are you running Gitea?

Built from source, from cli

Database

No response

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

It is possible to reopen merged prs via the api endpoint. This should be impossible

Screenshots

No response

[delvh]

Could you please clarify which endpoint you mean?
Because I just had a quick glance at https://try.gitea.io/api/swagger, and I have no idea which endpoint might be responsible for this.

[6543]

yes it is - if it's not working we need more infos&logs:

1. what specific endpoints do you rever to?
2. what gitea do print out in debug mode
3. what response the api return (body & header & status)

[noerw]

I understand the urge for detailed bug reports, but in this case it's just needless bureaucracy.. I was able to spot the problem here right away 🤔 (I guess I looked often enough at the openapi spec :D)
it's this request https://try.gitea.io/api/swagger#/repository/repoEditPullRequest

[qwerty287]

it's this request https://try.gitea.io/api/swagger#/repository/repoEditPullRequest

Yes, it is, and it is probably the same (not tested) here: https://try.gitea.io/api/swagger#/issue/issueEditIssue

[qwerty287]

@6543 it's the same if I reopen a closed issue or PR - status code is 201, and the answer is the pull request.