Ldap Admin UI looses encryption settings on save

[gtudan]

Gitea Version

1.16.1

Operating System

Linux

Browser Version

Safari 15.3

Can you reproduce the bug on the Gitea demo site?

No

Description

When I edit an LDAP Authentication source without touching the encryption settings and submit the form, the encryption settings will revert to "unencrypted". Then I have to edit the form again and select (for example) StartTLS.

The encryption status is shown correct, but will still revert to unencrypted unless I explicitly set it to StartTLS before saving.

Screenshots

[tcpluess]

I can confirm this. Also, since I updated to 1.16.1, the LDAP authentication seems to be broken and users can no longer sign in at all. However it is difficult to debug, is there somewhere an option to see the LDAP error messages?
perhaps it would be good to have a LDAP test possibility.

[lunny]

I can confirm this. Also, since I updated to 1.16.1, the LDAP authentication seems to be broken and users can no longer sign in at all. However it is difficult to debug, is there somewhere an option to see the LDAP error messages? perhaps it would be good to have a LDAP test possibility.

There are some PRs have been merged into v1.16.2 and will be released soon.

[tcpluess]

lunny,
this is awesome, thanks.
In my situation, I have a couple users that are waiting to be able to use gitea again.
I am wonderin whether it is smarter to restore the backup, which is 1 week old, and lose one week of work on the server, OR whether I should wait for 1.16.2. Unfortnately I realised that it is not possible to downgrade after I found out that the login does not work.

[gtudan]

Maybe try to reconfigure LDAP - in my case it helped to reset the encryption field and save again.

…

Am 22.02.2022 um 10:21 schrieb tcpluess ***@***.***>: lunny, this is awesome, thanks. In my situation, I have a couple users that are waiting to be able to use gitea again. I am wonderin whether it is smarter to restore the backup, which is 1 week old, and lose one week of work on the server, OR whether I should wait for 1.16.2. Unfortnately I realised that it is not possible to downgrade after I found out that the login does not work. — Reply to this email directly, view it on GitHub <#18766 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADGMYKUSDIUBQ2SGGNJWETU4NIRJANCNFSM5OLLEBEA>. You are receiving this because you authored the thread.

[tcpluess]

Maybe try to reconfigure LDAP - in my case it helped to reset the encryption field and save again.
…
Am 22.02.2022 um 10:21 schrieb tcpluess @.***>: lunny, this is awesome, thanks. In my situation, I have a couple users that are waiting to be able to use gitea again. I am wonderin whether it is smarter to restore the backup, which is 1 week old, and lose one week of work on the server, OR whether I should wait for 1.16.2. Unfortnately I realised that it is not possible to downgrade after I found out that the login does not work. — Reply to this email directly, view it on GitHub <#18766 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADGMYKUSDIUBQ2SGGNJWETU4NIRJANCNFSM5OLLEBEA. You are receiving this because you authored the thread.

Just checked, I cannot confirm this. I see that the encryption gets occasionally reset to "unencrypted" when I open the admin panel.

To also to confirm, I restored the backup from Jan 30, where I had Gitea 1.15.11 installed with the exact same configuration. This works fine. With 1.16.1 it does not work. However, restoring the backup also means that all database changes since Jan 30 are lost....

[lunny]

I think #18856 should fix this.

[richmahn]

@lunny has it been verified that #18856 fixes it?

[tcpluess]

@richmahn I can confirm that my gitea instance works now again.
1.15.x worked with LDAP, when I updated to 1.16.x a couple days ago LDAP was broken.
With the newest PRs, it seems to work again. I am now using 1.16.1+36-gf5a3c0dd6.