You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A few times I have been typing a long comment or post and accidently clicked a link or refreshed the page. Then all my work is gone and non-recoverable. I would appreciate having a "Leave Site?" dialogue box if I have unsaved content in a text box.
Activity
wxiaoguang commentedon Jul 13, 2022
Related:
silverwind commentedon Jul 14, 2022
There is already a warning via
jquery.are-you-sure
, but I'm not sure whether it will catch all changes, I think it only looks at stuff inside<form>
.Also, we really need to eliminate all cases of
window.reload
in JS. Might require new APIs to be added thought.Make issue meta dropdown support Enter, confirm before reloading (#23014
Make issue meta dropdown support Enter, confirm before reloading (go-…
Make issue meta dropdown support Enter, confirm before reloading (#23014
wxiaoguang commentedon Mar 2, 2023
Some details & background:
Before SimpleMDE/EasyMDE, there is a global
$.areYourSure
confirm (using onbeforeunload) for comment textarea. Everything was just "fine".However, after introducing SimpleMDE/EasyMDE,
$.areYourSure
doesn't work well with SimpleMDE/EasyMDE editor, so the situation became what you see now.silverwind commentedon Mar 2, 2023
Another reason to add to the list of like 30+ other issues on why we should remove EasyMDE and replace it with a textarea.
wxiaoguang commentedon Mar 2, 2023
I could also agree to remove the EasyMDE if there is no strong objection from user side.
silverwind commentedon Mar 2, 2023
Yes I think the majority of users is for it, see #10729.
wxiaoguang commentedon Mar 2, 2023
Then let's do it?
silverwind commentedon Mar 2, 2023
Yes, I think the approach in #15394 with the github toolbar is still ideal. If you have the capacity to do it, please go ahead, I'm happy to review.
lunny commentedon Apr 3, 2023
Should be fixed by #23895
silverwind commentedon Apr 3, 2023
Works now with #23876