Deleting an org avatar breaks the image

[tboerger]

• Gitea version (or commit ref): 1.1.2
• Git version: n/a
• Operating system: docker
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL): https://try.gitea.io/foobar
  • No
  • Not relevant
• Log gist: n/a

Description

I have uploaded a custom avatar for my organization, afterwards I have deleted it again and than the org avatar is broken. No page is loading any avatar anymore. I would expect that I get an auto-generated Gravatar image again.

Screenshots

[lunny]

This bug maybe reproduced on master?

[ethantkoenig]

Also, after the avatar breaks, the GET /orgs/:orgname API endpoint for the organization gives a 500.

I'm guessing this is because org.RelAvatarLink() is returning an empty string, so there is an out-of-index error at https://github.com/go-gitea/gitea/blob/master/models/user.go#L361

[tboerger]

@lunny try.gitea.io is based on master.

[lunny]

So let's mark it as v1.2 and back port to v1.1.3

[ethantkoenig]

@tboerger @lunny Fixed? (see https://try.gitea.io/foobar)

[lunny]

@ethantkoenig @tboerger seems yes.

[lunny]

@ethantkoenig please backport to v1.1

[lunny]

closed by #2083