Skip to content

Unneccessary SMTP_ADDR lookup when using "PROTOCOL = sendmail" #22287

@markshep

Description

@markshep

Description

I've just upgraded to 1.18.0 and had to fix my [mailer] config to avoid #22274 (and also update my [log] config just to see the problem in the first place!). Now that I can see warnings in the console I noticed this:

2022/12/30 21:49:49 ...es/setting/mailer.go:263:tryResolveAddr() [W] could not look up mailer.SMTP_ADDR: lookup : no such host

However it makes no sense for gitea to be attempting to resolve SMTP_ADDR as I'm using the "sendmail" PROTOCOL for my mailer:

[mailer]
ENABLED       = true
FROM          = Gitea <gitea@re.da.ct.ed>
PROTOCOL      = sendmail
SENDMAIL_PATH = /usr/sbin/sendmail
SENDMAIL_ARGS = --

Gitea Version

1.18.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Debian 11.6 (amd64)

How are you running Gitea?

Downloaded from your GitHub release page.

Database

None

Activity

lunny

lunny commented on Dec 31, 2022

@lunny
Member

22295 is a wrong ref.

added this to the 1.18.1 milestone on Dec 31, 2022
added a commit that references this issue on Jan 9, 2023
99a675f
added a commit that references this issue on Jan 9, 2023
ca15ac5
added a commit that references this issue on Jan 9, 2023
32999e2
locked and limited conversation to collaborators on May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      Participants

      @lunny@markshep

      Issue actions

        Unneccessary SMTP_ADDR lookup when using "PROTOCOL = sendmail" · Issue #22287 · go-gitea/gitea