Skip to content

Latest main breaks PRs with comments #22961

Closed
@gempir

Description

@gempir
Contributor

Description

Adding a comment to a PR will cause the PR page to only answer with a 500.
I tried it on the 2 commits below and also the gitea demo instance.

Not sure at what point this bug came.

https://try.gitea.io/gempir/gempbot/pulls/1/files

Server error message:

2023/02/17 21:01:44 ...s/context/context.go:231:HTML() [E] [63efdd28-32] Render failed: template: shared/user/avatarlink:1:81: executing "shared/user/avatarlink" at <$.Context>: wrong type for value; expected context.Context; got interface {}
2023/02/17 21:01:44 [63efdd28-32] router: completed GET /gempir/gempbot/pulls/2/files for [::1]:33960, 500 Internal Server Error in 101.7ms @ repo/pull.go:672(repo.ViewPullFiles)

Test commits which were all broken (so has to be before):
Powered by Gitea Version: 1.19.0+dev-504-ge7ef94e00 Page: 187ms Template: 1ms
e7ef94e
bd820aa

Gitea Version

e7ef94e

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

locally on linux with the make command in the readme. But also happens on the try.gitea.io page.

Database

SQLite

Activity

yardenshoham

yardenshoham commented on Feb 17, 2023

@yardenshoham
Member

How to reproduce?

gempir

gempir commented on Feb 17, 2023

@gempir
ContributorAuthor

Just add a comment on a code line

added
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implemented
on Feb 17, 2023
added this to the 1.19.0 milestone on Feb 17, 2023
yardenshoham

yardenshoham commented on Feb 17, 2023

@yardenshoham
Member

Feels like a regression from #22294, reminds me of #22924

added a commit that references this issue on Feb 20, 2023
8e9814c
locked and limited conversation to collaborators on May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedtype/bug

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      Participants

      @gempir@yardenshoham

      Issue actions

        Latest main breaks PRs with comments · Issue #22961 · go-gitea/gitea