OAuth registration flow doesn't respect manual confirmation requirement #23392
Description
Description
Hi all,
The OAuth registration flow will log a newly registered user in regardless of the value of GITEA__service__REGISTER_MANUAL_CONFIRM.
Where the standard registration flow creates a user and lets handleUserCreated() activate it if appropriate, the OAuth flow will activate the user, conditional only on GITEA__service__REGISTER_EMAIL_CONFIRM, thereby bypassing the manual-approval check in handleUserCreated().
It's not clear to me whether or not the activation overwrite in oauth.go is actually necessary at all.
Gitea Version
1.17.4
Operating System
Linux
How are you running Gitea?
Docker
Database
PostgreSQL