Skip to content

Dark theme: release descripton doesn't look good #23718

@wxiaoguang

Description

@wxiaoguang
Contributor

Description

https://try.gitea.io/wxiaoguang/test/releases

  1. Padding/Margin
  2. Background color

image

Activity

zeripath

zeripath commented on Mar 26, 2023

@zeripath
Contributor

in comments the markup gets a border:

.comment-body .markup {
  padding: 1em;
  border-radius: 0 0 var(--border-radius) var(--border-radius); /* don't render outside box */
}

We could just add gt-px-3 gt-py-3 to the class?

I guess the question is how to ensure it looks ok in the non-arc-green theme

wxiaoguang

wxiaoguang commented on Mar 27, 2023

@wxiaoguang
ContributorAuthor

I think it's caused by incorrect background color (introduced by https://github.com/go-gitea/gitea/pull/23578/files#r1149604909 )

Without the background: var(--color-box-body); or use inherit, the UI looks fine.

locked as resolved and limited conversation to collaborators on May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @zeripath@wxiaoguang

      Issue actions

        Dark theme: release descripton doesn't look good · Issue #23718 · go-gitea/gitea