Semicolons in locale_en-US.ini

[kzmi]

Description

There is an issue with the locale_en-US.ini file where the following four keys contain semicolons:

• settings.protect_protected_file_patterns
• settings.protect_protected_file_patterns_desc
• settings.protect_unprotected_file_patterns
• settings.protect_unprotected_file_patterns_desc

The semicolons are causing problems because Crowdin treats a semicolon as the beginning of a comment:

This leads to the following issues:

• The part of the text after the semicolon cannot be translated.
• Crowdin appends the original comment to the end of the translation. (see locale_zh-CN.ini)

It may be possible to enclose the text in double quotes to prevent Crowdin from treating the semicolon as a comment.

Gitea Version

265675a

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Database

None

[lunny]

I think most of the translations have the same problems. Maybe we need some translations lint when pushing.

[wxiaoguang]

I have removed most semicolons in en-US.ini. Those are the last four. Luckily, these four doesn't break the translations too much, it only causes that part of the sentence doesn't get translated.

This time I will do a quick patch , try to use \; as before, or try to see if " works for both (crowdin & Gitea)

Next time I will propose a complete PR.

[wxiaoguang]

See:

• Clarify Gitea/Crowdin locale behaviors, add tests for LocaleStore, fix some strings with semicolons #23819

[wxiaoguang]

A hint: I guess we couldn't do settings.protect_protected_file_patterns=`"... '\;' ... " ;'):`` (eg: the last commit )

#23819 uses key="x='y'; z" , I guess it should work well for both Gitea and Crowdin. Let's wait for next sync.