Skip to content

Feishu webhook of issue update not linking to full issue url #24368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xgdgsc opened this issue Apr 27, 2023 · 8 comments · Fixed by #25106
Closed

Feishu webhook of issue update not linking to full issue url #24368

xgdgsc opened this issue Apr 27, 2023 · 8 comments · Fixed by #25106
Labels

Comments

@xgdgsc
Copy link

xgdgsc commented Apr 27, 2023

Feature Description

I hope webhook of issue update include issue url. I find it strange commit webhook has URL while issue webhook notifications has no URL, which I usually would use more frequently,

Screenshots

No response

@xgdgsc xgdgsc added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Apr 27, 2023
@Makonike
Copy link
Contributor

Makonike commented Jun 5, 2023

hi, @xgdgsc . Can you please reproduce and provide a detailed description of the issue? I'm not quite clear on what "issue webhook notifications has no URL" means. It's possible that this issue has already been resolved in the latest version.

image

@xgdgsc
Copy link
Author

xgdgsc commented Jun 6, 2023

I see only

{
  "msg_type": "text",
  "content": {
    "text": "#2 tst1\r\n[org/repo1] Issue closed: #2 tst1 by user1"
  }
}

when using Feishu webhook.

@techknowlogick techknowlogick changed the title webhook of issue update not including issue url Feishu webhook of issue update not linking to full issue url Jun 6, 2023
@techknowlogick techknowlogick added type/bug and removed type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jun 6, 2023
@techknowlogick
Copy link
Member

@xgdgsc which version of gitea are you using?

@xgdgsc
Copy link
Author

xgdgsc commented Jun 6, 2023

Just downloaded latest release 1.19.3

@Makonike
Copy link
Contributor

Makonike commented Jun 6, 2023

I will fix this later.

@Makonike
Copy link
Contributor

Makonike commented Jun 6, 2023

hi @xgdgsc, I have submitted a Pull Request to fix this issue. Since the official documentation states that custom webhook bots do not support hyperlink functionality, simply adding it without making some formatting changes would result in an unappealing output. Therefore, I have modified the formatting of the output. You can also try using a custom bot application. I have previously written one that you can refer to. The repository is located here: webhook2group

@xgdgsc
Copy link
Author

xgdgsc commented Jun 8, 2023

The commit notification message already has the url, which is fine and clickable. So I think just adding the url to the text would be fine? I' ve never used any custom bot before, just used the webhook bot.

@Makonike
Copy link
Contributor

Makonike commented Jun 8, 2023

The commit notification message already has the url, which is fine and clickable. So I think just adding the url to the text would be fine? I' ve never used any custom bot before, just used the webhook bot.

Yeah, my PullRequest will fix this.

lunny pushed a commit that referenced this issue Aug 24, 2023
close #24368

## what my pull request does

Since the official documentation states that custom bots do not support
hyperlink functionality, simply adding it without making some formatting
changes would result in an unappealing output. Therefore, I have
modified the formatting of the output. Currently, it is only used for
Feishu.

--- 


[docs](https://open.feishu.cn/document/uAjLw4CM/ukTMukTMukTM/im-v1/message/create_json#%E8%B6%85%E9%93%BE%E6%8E%A5%E4%BD%BF%E7%94%A8%E8%AF%B4%E6%98%8E)

<img width="641" alt="image"
src="https://github.com/go-gitea/gitea/assets/75628309/360e1c81-ab64-4ef6-851e-aa450d6e85a4">

- Issue

<img width="423" alt="image"
src="https://github.com/go-gitea/gitea/assets/75628309/519f6fae-81ab-4ec8-89b8-f6a73ff93783">


- Issue Comment


<img width="548" alt="image"
src="https://github.com/go-gitea/gitea/assets/75628309/749c0d1c-3657-431e-b787-8bf4c23cce83">


- Assign

<img width="431" alt="image"
src="https://github.com/go-gitea/gitea/assets/75628309/066f99e5-eabb-455d-91fb-a8359cc26dc7">

<img width="457" alt="image"
src="https://github.com/go-gitea/gitea/assets/75628309/c6c10f99-db83-46ef-a775-4c91979fa68f">

- Merge

<img width="408" alt="image"
src="https://github.com/go-gitea/gitea/assets/75628309/e627bf43-5954-45aa-acf6-261ee046802f">

- PullRequest

<img width="425" alt="image"
src="https://github.com/go-gitea/gitea/assets/75628309/72cfa714-d3fa-4fb9-abdd-e8508d756056">
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants