List a team's member API `page` parameter is 0-based (should be 1-based)

[yamadayutaka]

Description

In the API specification, page is supposed to be specified as 1-based.

https://try.gitea.io/api/swagger#/organization/orgListTeamMembers

However, it seems to be implemented with 0-based. (Please see screenshots)

Gitea Version

1.19.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Target Organization/Team

Result when page=1 is specified

Result when page=0 is specified

Git Version

No response

Operating System

No response

How are you running Gitea?

Installed with Helm chart and running on Kubernetes.

Override values

service:
  http:
    type: LoadBalancer

Install command

helm install gitea gitea-charts/gitea --version 8.3.0 -f override-values.yaml

Database

None

[yardenshoham]

The fix would be a breaking change so this shouldn't go in 1.19.4

[lunny]

It should be a bug, because the API documentation said it's 1 based.

[yardenshoham]

I agree it's a bug. The fix itself would be a breaking change so it should be fixed in 1.20